1620656 - Remove GeckoView Telemetry Snapshotting during or after Firefox 79 (June-ish 2020)

Status: RESOLVED FIXED

(Toolkit :: Telemetry, task, P1)

Description

[Chris H-C :chutten]

bug 1620395 should have deprecated GeckoView Telemetry Snapshoting. Now that it's been three versions, we can (probably) remove it.

Double check with Focus that we can do this, then remove the API. Removing the code would be nice, too, but the biggest part is that we need to remember to disable it enough that it doesn't start the TelemetryGVIO thread: that's the whole reason we're doing this.

Comment 1

[Chris H-C :chutten]

This bug can be about disabling or removing, your choice.

Do remember to update the Histograms, Scalars, and Events documentation that a value of "geckoview" is now no longer allowed.

Comment 2

[Kevin Brosnan [Ex-Mozilla]]

Talked with Jon and he opened an issue for Focus to track moving over to Glean.

Comment 3

[Eugen Sawin [:esawin]]

The public API has been removed in bug 1644447. It should be safe to remove the backend implementation now.

Comment 4

[Alessio Placitelli [:Dexter]]

Attachment: Bug 1620656 - Remove 'geckoview' telemetry support. r?chutten

This removes the support for the 'geckoview' telemetry in
the core and in the JSM files. It also cleans up testing
and the configurations.

Comment 5

[Alessio Placitelli [:Dexter]]

Attachment: Bug 1620656 - Disable 'geckoview' in the registry files. r?chutten

Depends on D79521

Comment 6

[Alessio Placitelli [:Dexter]]

Attachment: Bug 1620656 - Fix tests broken by removing 'geckoview' telemetry. r?chutten

Depends on D79522

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dd0ce5e4a1bf
Remove 'geckoview' telemetry support. r=chutten,geckoview-reviewers,aklotz
https://hg.mozilla.org/integration/autoland/rev/f0b502580ef0
Disable 'geckoview' in the registry files. r=chutten
https://hg.mozilla.org/integration/autoland/rev/af6b36a497e8
Fix tests broken by removing 'geckoview' telemetry. r=janerik

Comment 8

[Atila Butkovits]

Backed outfor causing bustage at TestGeckoView.

Backout link: https://hg.mozilla.org/integration/autoland/rev/954520f4896489ae4b7cbb2e95484ae03556d638

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&revision=af6b36a497e87e92a101891773fd0b1f3cbf9c64&selectedTaskRun=V980383FSqq1R3UVqEVkCQ.0

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=306466729&repo=autoland&lineNumber=37558

Comment 9

[Alessio Placitelli [:Dexter]]

Whoops. Sorry, I fixed the commits: green try -> https://treeherder.mozilla.org/#/jobs?repo=try&revision=1a2c90ffbe38ff6519e5a92f6745bde6969759c4&selectedTaskRun=NznUgxilRaOZ2rD1n2lw0A.0

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5409134fc766
Remove 'geckoview' telemetry support. r=chutten,geckoview-reviewers,aklotz
https://hg.mozilla.org/integration/autoland/rev/d009c756c86b
Disable 'geckoview' in the registry files. r=chutten
https://hg.mozilla.org/integration/autoland/rev/dfab5bc68cde
Fix tests broken by removing 'geckoview' telemetry. r=janerik

Comment 11

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/5409134fc766
https://hg.mozilla.org/mozilla-central/rev/d009c756c86b
https://hg.mozilla.org/mozilla-central/rev/dfab5bc68cde