Open Bug 1620789 Opened 5 years ago Updated 4 years ago

Add source code download and build instructions to the website

Categories

(SeaMonkey :: Website, enhancement)

Product:
SeaMonkey
Component:
Website
Version:
Production
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
ASSIGNED

People

(Reporter: iannbugzilla, Assigned: iannbugzilla)

References

Details

Attachments

(4 files, 2 obsolete files)

1620789-dev-part1-v1_1.patch
6.83 KB, patch
frg
: review+
Details | Diff | Splinter Review
1620789-code-dev-v1_1-2536.patch
19.25 KB, patch
frg
: review+
Details | Diff | Splinter Review
1620789-building-title.patch
2.54 KB, patch
frg
: review+
Details | Diff | Splinter Review
1620789-remove-extensions.patch [Checked in: Comment 16]
2.43 KB, patch
iannbugzilla
: review+
Details | Diff | Splinter Review

Most of the build instructions available from Mozilla are out of date / no longer suitable for SeaMonkey.

Attached patch WIP patch (obsolete) — — Splinter Review

Before I get too far, want to make sure I am going in generally the right direction.

Attachment #9131711 - Flags: feedback?(frgrahl)
Comment on attachment 9131711 [details] [diff] [review] WIP patch Looks good. I would stop here describing building. Setting up a build environment is complex. I have Windows instructions in a pdf available. Maybe we should rework and add these for download and then do Linux and macOS cross compiles later. Might otherwise become a big/complex page with illustrations.
Attachment #9131711 - Flags: feedback?(frgrahl) → feedback+

Latest version of part 1.
Still some refinement required and parts need adding but a good starting point for uploading.

Attachment #9131711 - Attachment is obsolete: true
Attachment #9194879 - Flags: review?(frgrahl)

Comment on attachment 9194879 [details] [diff] [review]
1620789-dev-part1-v1_1.patch

Thanks post review.

For followups.

nasm-2.15.x,

2.14.x is required

rustc-1.47.0 (or 1.38.0 for 2.57)

1.38 is the minimum but 1.47.0 preferred for 2.53. 1.37 is currently needed for 2.57 because of unfixed stylo breakage in cssparser. 1.38 will only work if disabling webrender and stylo.

Attachment #9194879 - Flags: review?(frgrahl) → review+
Attached patch 1620789-code-dev-2536.patch (obsolete) — — Splinter Review

Addressed review comments and also moved code development into its own page as it was taking up too much space on the main page.

Attachment #9195519 - Flags: review?(frgrahl)

New version, spotted some missing closing tags.

Attachment #9195519 - Attachment is obsolete: true
Attachment #9195519 - Flags: review?(frgrahl)
Attachment #9195520 - Flags: review?(frgrahl)
Blocks: 1685603

Comment on attachment 9195520 [details] [diff] [review]
1620789-code-dev-v1_1-2536.patch

lgtm.

one nit: checkout instructions for DOMi should be dropped from 2.57 and central.

Attachment #9195520 - Flags: review?(frgrahl) → review+

At https://www.seamonkey-project.org/dev/, there is a "bug reporting" link to http://developer.mozilla.org/en/docs/Bug_writing_guidelines which no longer exists.

I assume it's the page found at https://developer.mozilla.org/en-US/docs/Mozilla/QA/Bug_writing_guidelines whither it has been arbitrarily moved, the content at the new location being from 2013.

It should still be applicable to SeaMonkey for the moment.

Also Rainer Bielefeld wrote:

...
Also https://developer.mozilla.org/en-US/docs/QA behind "QA section" does not exist.

Do you know to where this one should lead?

Looks like https://developer.mozilla.org/en-US/docs/Mozilla/QA but this may not be so relevant. Probably SM dev guidance will need its own page from which to curate links to Moz.

(In reply to fieldhouse from comment #10)

At https://www.seamonkey-project.org/dev/, there is a "bug reporting" link to http://developer.mozilla.org/en/docs/Bug_writing_guidelines which no longer exists.

I assume it's the page found at https://developer.mozilla.org/en-US/docs/Mozilla/QA/Bug_writing_guidelines whither it has been arbitrarily moved, the content at the new location being from 2013.

It should still be applicable to SeaMonkey for the moment.

Also Rainer Bielefeld wrote:

...
Also https://developer.mozilla.org/en-US/docs/QA behind "QA section" does not exist.

Do you know to where this one should lead?

Looks like https://developer.mozilla.org/en-US/docs/Mozilla/QA but this may not be so relevant. Probably SM dev guidance will need its own page from which to curate links to Moz.

Looks like they recently removed a redirect that was happening on developer.mozilla.org, thanks for reporting. Fix pushed:
https://gitlab.com/seamonkey-project/website/-/commit/b3de0bcfd5763c58d843e47369d4004f84ec1155
https://gitlab.com/seamonkey-project/website/-/commit/6c937b373433551542af79820b717db35d7edc0c
https://hg.mozilla.org/SeaMonkey/seamonkey-project-org/rev/4f0e2ba47c5a36d438ec09409b6beaf14f00ceba

Rename the page

Attachment #9198889 - Flags: review?(frgrahl)

Comment on attachment 9198889 [details] [diff] [review]
1620789-building-title.patch

LGTM

Attachment #9198889 - Flags: review?(frgrahl) → review+

Now we have imported the cZ and DOMi code into our repo, we don't need to include cloning them separately in our build guidance.

Attachment #9219698 - Flags: review+

The section on the page https://www.seamonkey-project.org/dev/code-development on pre-requisites needs to be changes so that instead of just saying autoconf 2.13 says something like autoconf 2.13 (this version exactly neither older nor newer versions will work)

No longer blocks: 1685603
See Also: → 1685603
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: