1620832 - lld-link: error: undefined symbol: _GetFileVersionInfoSizeW

Status: RESOLVED FIXED

(Thunderbird :: Build Config, defect)

Description

[Richard Marti (:Paenglab)]

treeherder and I get following errors
0:16.00 lld-link: error: undefined symbol: GetFileVersionInfoSizeW
0:16.00 >>> referenced by ......\security\sandbox\file_version_info_win.obj:(public: static class std::unique_ptr<class FileVersionInfoWin, struct std::default_delete<class FileVersionInfoWin>> __cdecl FileVersionInfoWin::CreateFileVersionInfoWin(class base::FilePath const &))
0:16.00 lld-link: error: undefined symbol: GetFileVersionInfoW
0:16.00 >>> referenced by ......\security\sandbox\file_version_info_win.obj:(public: static class std::unique_ptr<class FileVersionInfoWin, struct std::default_delete<class FileVersionInfoWin>> __cdecl FileVersionInfoWin::CreateFileVersionInfoWin(class base::FilePath const &))
0:16.00 lld-link: error: undefined symbol: VerQueryValueW
0:16.00 >>> referenced by ......\security\sandbox\file_version_info_win.obj:(public: static class std::unique_ptr<class FileVersionInfoWin, struct std::default_delete<class FileVersionInfoWin>> __cdecl FileVersionInfoWin::CreateFileVersionInfoWin(class base::FilePath const &))
0:16.00 >>> referenced by ......\security\sandbox\file_version_info_win.obj:(public: static class std::unique_ptr<class FileVersionInfoWin, struct std::default_delete<class FileVersionInfoWin>> __cdecl FileVersionInfoWin::CreateFileVersionInfoWin(class base::FilePath const &))
0:16.00 >>> referenced by ......\security\sandbox\file_version_info_win.obj:(private: __cdecl FileVersionInfoWin::FileVersionInfoWin(class std::vector<unsigned char, class std::allocator<unsigned char>> &&, unsigned short, unsigned short))

When I back-out bug 1615401 my build is successful.

Comment 1

[Rob Lemley [:rjl]]

Attachment: Include version.dll when linking thunderbird.exe

This compiles anyway. No idea what the implications of doing that are.

Comment 2

[Rob Lemley [:rjl]]

Comment on attachment 9131745 [details] [diff] [review]
Include version.dll when linking thunderbird.exe

https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=0deacf7d1d4693419b300d90ebd3677e58066c66

I'm inclined to wait for the unittests to run before landing.

Comment 3

[Richard Marti (:Paenglab)]

Comment on attachment 9131745 [details] [diff] [review]
Include version.dll when linking thunderbird.exe

Thanks! Works locally.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/5c68b2fdcca6
Include version.dll when linking thunderbird.exe. r=Paenglab