Closed Bug 1620876 Opened 4 years ago Closed 4 years ago

play.gl is black on Linux

Categories

(Core :: Graphics: CanvasWebGL, defect, P1)

Unspecified
All
defect

Tracking

()

RESOLVED FIXED
mozilla75
Tracking Status
firefox-esr68 --- unaffected
firefox73 --- unaffected
firefox74 + fixed
firefox75 + fixed

People

(Reporter: emilio, Assigned: jgilbert)

References

(Regression)

Details

(Keywords: regression)

Attachments

(2 files)

https://play.gl/ shows only black on nightly, but it works on 73.

There are tons of warnings, one about context lost, a bunch of them about using an unlinked program.

Flags: needinfo?(jgilbert)
Keywords: regression
Regressed by: 1617512
Has Regression Range: --- → yes

Ugh, you're kidding me.

Flags: needinfo?(jgilbert)
Assignee: nobody → jgilbert
Priority: -- → P1

I see it broken on Windows, works in Chrome.

OS: Unspecified → All

[Tracking Requested - why for this release]: Regressing patch made it to beta.

The "regressing patch" is fixing a regression itself, so I don't want to back it out.

In'//\n', /[^\\]\n/ doesn't match '\n' following '//'. :(
I'm amazed the tests didn't catch this.

Pushed by jgilbert@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/cad7268d33b0
Handle "//\n" webglsl comments. r=lsalzman

This is more serious than bug 1617512. I expect this to break noticeable content.

Comment on attachment 9131799 [details]
Bug 1620876 - Handle "//\n" webglsl comments.

Beta/Release Uplift Approval Request

  • User impact if declined: Likely broken content, including at least play.gl.
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Easy to understand bug, straightforward fix.

If we don't take this, we should remove bug 1617512's fix from 74.

  • String changes made/needed: none
Attachment #9131799 - Flags: approval-mozilla-beta?

Comment on attachment 9131799 [details]
Bug 1620876 - Handle "//\n" webglsl comments.

74 is on mozilla-release and ships tomorrow...

Attachment #9131799 - Flags: approval-mozilla-beta? → approval-mozilla-release?
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla75

Comment on attachment 9131799 [details]
Bug 1620876 - Handle "//\n" webglsl comments.

We are not taking the uplift, we are backing out bug 1617512 and building a RC3 instead.

Attachment #9131799 - Flags: approval-mozilla-release? → approval-mozilla-release-

Fixed in 74RC3 by the backout in bug 1617512

You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: