Closed Bug 1624275 Opened 5 years ago Closed 5 years ago

OpenGL shader crash in Firefox 74

Categories

(Core :: Graphics: CanvasWebGL, defect)

74 Branch
defect
Not set
normal

Tracking

()

RESOLVED DUPLICATE of bug 1620876

People

(Reporter: florian.richer, Unassigned)

References

(Regression)

Details

(Keywords: regression)

Attachments

(1 file)

User Agent: Mozilla/5.0 (X11; Fedora; Linux x86_64; rv:74.0) Gecko/20100101 Firefox/74.0

Steps to reproduce:

I'm exported a default godot project with a default material in Mesh.

The default project and my html5 export is available in https://github.com/godotengine/godot/issues/37245 .

Actual results:

I get this error since firefox 74.
ERROR: Condition "!version" is true. Returned: -1
At: drivers/gles2/shader_gles2.h:257:_get_uniform() - Condition "!version" is true. Returned: -1

Expected results:

In firefox 73 my default program work perfectly without any error.

I can reproduce the same issue on Firefox 74.0 on Linux (from https://download-installer.cdn.mozilla.net/pub/firefox/releases/74.0/linux-x86_64/en-US/ ), using the reproduction project from comment 1. Note that you need to serve it over a HTTP server for it to run, e.g. python3 -m http.server.

It happens both with Intel HD Graphics 630 and AMD Radeon RX Vega M on my system.

Firefox 73.0.1, Firefox Beta 75.0b8 and Firefox Nightly 76.0a1 do not reproduce the issue, so it seems that it was a regression specific to Firefox 74.0 which has since been solved.

If a Firefox 74.0.1 release is planned, identifying and backporting the fix would be welcome, as this regression likely breaks a number of WebGL-based projects (including many games developed with the open source Godot Engine).

Adding a component to this issue in order to get the dev team involved.
If it's not the right one please feel free to change it to a more appropriate one.

Component: Untriaged → Canvas: WebGL
Product: Firefox → Core

Testing on linux, as per comment 2 instructions. This change broke it: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=5cbf5bb11c585d69321b420f67ffb62544141427&tochange=e1b0906509efa6433978b9f980ec639b7eafbc6d

And this change fixed it again: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=24dc59fa7381d59c6c72e45bd65199fb71bf3043&tochange=cad7268d33b0b922373221a1f34b4fbdb7884288

The fixing patch didn't make it in to 74, and instead bug 1617512 was reverted. Unfortunately that doesn't seem to have helped in this case, though.

Status: UNCONFIRMED → RESOLVED
Closed: 5 years ago
Regressed by: webgl-ipc-refactor
Resolution: --- → DUPLICATE
Has Regression Range: --- → yes
Keywords: regression
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: