1620879 - Export margin-collapsing tests to WPT

Status: NEW

(Core :: Layout: Block and Inline, task)

Description

[Sam Sneddon [:gsnedders]]

If any work is going to be done on margin-collapsing, it would be good to have a good margin-collapsing test suite in WPT so we can readily see what browsers pass what tests. There is a good test suite in m-c, so let's just export it. 🙃

Comment 1

[Sam Sneddon [:gsnedders]]

Attachment: Bug 1620879 - export margin-collapsing tests

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Could you explain the process you used to produce this diff?

Diffs that are... too large for phabricator to show are rather painful to work with...

Comment 3

[Sam Sneddon [:gsnedders]]

Oh, I'd meant to link to the script. It's now at https://gist.github.com/gsnedders/38df4e1b40011c9a910d7aa1a8230f4f (the process was move everything, run that script, deal with the one file it fails to deal with (margin-collapsing/block-xml-root-1.xml), then commit).

The script isn't anywhere near good enough for general usage (it just drops most annotations, for one!), but it does deal with everything in that reftest.list

Comment 4

[Sam Sneddon [:gsnedders]]

(ping, dbaron)

Comment 5

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: reftest-convert.py

script, from the above gist

Comment 6

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: number of times each file shows up in the reftest.list

Comment 7

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: number of times each file shows up as the <test> in the reftest.list

Comment 8

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: number of times each file shows up as the <reference> in the reftest.list

Comment 9

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

(No files show up in both <test> and <reference> position in the reftest.list.)

Comment 10

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Sorry for taking so long to finish that review.

Comment 11

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

I should note the majority of these tests come from bug 477462.

Comment 12

[Sam Sneddon [:gsnedders]]

As :dbaron noted in Phabricator, this needs permission from Daniel who originally wrote these (preferably in bug 1073556).

Comment 13

[Daniel.S]

Please consider any permission required from my side as granted.

The tests were specifically made to enable a refactoring of the margin collapsing logic, which was slow and outdated back then (maybe even now?). However, please note that the test suite is unfinished. I haven't worked on it for several years and I'm afraid I will probably not finish the task I set out for myself in bug 477462.