1620980 - Artifact builds broken on Win 2012 | WINE is not available in this configuration

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[James Graham [:jgraham]]

task 2020-03-09T10:39:08.832Z] 10:39:08    ERROR -  Traceback (most recent call last):
[task 2020-03-09T10:39:08.832Z] 10:39:08     INFO -    File "/builds/worker/checkouts/gecko/configure.py", line 172, in <module>
[task 2020-03-09T10:39:08.833Z] 10:39:08     INFO -      sys.exit(main(sys.argv))
[task 2020-03-09T10:39:08.833Z] 10:39:08     INFO -    File "/builds/worker/checkouts/gecko/configure.py", line 47, in main
[task 2020-03-09T10:39:08.833Z] 10:39:08     INFO -      sandbox.run(os.path.join(os.path.dirname(__file__), 'moz.configure'))
[task 2020-03-09T10:39:08.833Z] 10:39:08     INFO -    File "/builds/worker/checkouts/gecko/python/mozbuild/mozbuild/configure/__init__.py", line 455, in run
[task 2020-03-09T10:39:08.833Z] 10:39:08     INFO -      self._value_for(option)
[task 2020-03-09T10:39:08.833Z] 10:39:08     INFO -    File "/builds/worker/checkouts/gecko/python/mozbuild/mozbuild/configure/__init__.py", line 545, in _value_for
[task 2020-03-09T10:39:08.833Z] 10:39:08     INFO -      return self._value_for_option(obj)
[task 2020-03-09T10:39:08.833Z] 10:39:08     INFO -    File "/builds/worker/checkouts/gecko/python/mozbuild/mozbuild/util.py", line 1026, in method_call
[task 2020-03-09T10:39:08.833Z] 10:39:08     INFO -      cache[args] = self.func(instance, *args)
[task 2020-03-09T10:39:08.833Z] 10:39:08     INFO -    File "/builds/worker/checkouts/gecko/python/mozbuild/mozbuild/configure/__init__.py", line 608, in _value_for_option
[task 2020-03-09T10:39:08.834Z] 10:39:08     INFO -      % option_string.split('=', 1)[0])
[task 2020-03-09T10:39:08.835Z] 10:39:08     INFO -  mozbuild.configure.options.InvalidOptionError: WINE is not available in this configuration

From https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=292226990&repo=try&lineNumber=1395

Bug 1620165 and Bug 1620164 look somewhat suspicious.

Comment 1

[Mike Hommey [:glandium]]

Attachment: Bug 1620980 - Fix Windows artifact builds after bug 1620165.

Both Wine and UPX are necessary when doing artifact builds.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0126b708c92e
Fix Windows artifact builds after bug 1620165. r=froydnj

Comment 3

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/0126b708c92e

Comment 4

[Ryan VanderMeulen [:RyanVM]]

Please nominate this for Beta uplift when you get a chance.

Comment 5

[Mike Hommey [:glandium]]

(In reply to Ryan VanderMeulen [:RyanVM] from comment #4)

Please nominate this for Beta uplift when you get a chance.

Depends on the conclusion for https://bugzilla.mozilla.org/show_bug.cgi?id=1620165#c16

Comment 6

[Julien Cristau [:jcristau]]

Yeah, let's uplift.

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:glandium, is this bug important enough to require an uplift?
If not please set status_beta to wontfix.

For more information, please visit auto_nag documentation.

Comment 8

[Mike Hommey [:glandium]]

Comment on attachment 9132103 [details]
Bug 1620980 - Fix Windows artifact builds after bug 1620165.

Beta/Release Uplift Approval Request

• User impact if declined: Artifact builds failure
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): build system-only change that has been shown to work and not cause wreakage
• String changes made/needed: N/A

Comment 9

[Julien Cristau [:jcristau]]

Comment on attachment 9132103 [details]
Bug 1620980 - Fix Windows artifact builds after bug 1620165.

approved for beta75

Comment 10

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/releases/mozilla-beta/rev/7fc161afb0bf