Closed Bug 1620983 Opened 5 years ago Closed 5 years ago

Intermittent devtools/client/framework/test/*.js | A promise chain failed to handle a rejection: Connection closed, pending request to <path>, type listWorkers failed

Categories

(DevTools :: Framework, defect, P5)

defect

Tracking

(firefox78 fixed)

RESOLVED FIXED
Firefox 78
Tracking Status
firefox78 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: jdescottes)

References

Details

(Keywords: intermittent-failure)

Attachments

(1 file)

Filed by: malexandru [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer.html#?job_id=292247571&repo=autoland
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/ZuiyqogCScuLlOjGfVf1sw/runs/0/artifacts/public/logs/live_backing.log


[task 2020-03-09T12:59:05.324Z] 12:59:05     INFO - TEST-PASS | devtools/client/framework/test/browser_toolbox_tool_ready.js | The main process DevToolsServer has no pending connection when the test ends - 
[task 2020-03-09T12:59:05.325Z] 12:59:05     INFO - Console message: [JavaScript Error: "Error: Connection closed, pending request to server0.conn12.content-process24/contentProcessTarget1, type listWorkers failed
[task 2020-03-09T12:59:05.325Z] 12:59:05     INFO - 
[task 2020-03-09T12:59:05.325Z] 12:59:05     INFO - Request stack:
[task 2020-03-09T12:59:05.325Z] 12:59:05     INFO - request@resource://devtools/shared/protocol/Front.js:232:14
[task 2020-03-09T12:59:05.326Z] 12:59:05     INFO - generateRequestMethods/</frontProto[name]@resource://devtools/shared/protocol/Front/FrontClassWithSpec.js:47:19
[task 2020-03-09T12:59:05.327Z] 12:59:05     INFO - listAllWorkerTargets@resource://devtools/shared/fronts/root.js:183:38
[task 2020-03-09T12:59:05.327Z] 12:59:05     INFO - async*listAllServiceWorkers@resource://devtools/shared/fronts/root.js:75:20
[task 2020-03-09T12:59:05.327Z] 12:59:05     INFO - async*updateWorkers@resource://devtools/client/application/initializer.js:102:65
[task 2020-03-09T12:59:05.327Z] 12:59:05     INFO - _emit@resource://devtools/shared/event-emitter.js:226:34
[task 2020-03-09T12:59:05.327Z] 12:59:05     INFO - emit@resource://devtools/shared/event-emitter.js:172:18
[task 2020-03-09T12:59:05.327Z] 12:59:05     INFO - emit@resource://devtools/shared/event-emitter.js:324:18
[task 2020-03-09T12:59:05.327Z] 12:59:05     INFO - onPacket@resource://devtools/shared/protocol/Front.js:270:13
[task 2020-03-09T12:59:05.327Z] 12:59:05     INFO - onPacket@resource://devtools/shared/client/devtools-client.js:498:13
[task 2020-03-09T12:59:05.328Z] 12:59:05     INFO - send/<@resource://devtools/shared/transport/local-transport.js:68:25
[task 2020-03-09T12:59:05.328Z] 12:59:05     INFO - exports.makeInfallible/<@resource://devtools/shared/ThreadSafeDevToolsUtils.js:111:22
[task 2020-03-09T12:59:05.328Z] 12:59:05     INFO - DevToolsUtils.executeSoon*exports.executeSoon@resource://devtools/shared/DevToolsUtils.js:62:21
[task 2020-03-09T12:59:05.328Z] 12:59:05     INFO - send@resource://devtools/shared/transport/local-transport.js:56:21
[task 2020-03-09T12:59:05.328Z] 12:59:05     INFO - send@resource://devtools/server/devtools-server-connection.js:91:20
[task 2020-03-09T12:59:05.328Z] 12:59:05     INFO - onWorkerListChanged@resource://devtools/server/actors/root.js:475:15
[task 2020-03-09T12:59:05.328Z] 12:59:05     INFO - _notifyListChanged@resource://devtools/server/actors/worker/worker-target-actor-list.js:184:10
[task 2020-03-09T12:59:05.328Z] 12:59:05     INFO - onUnregister@resource://devtools/server/actors/worker/worker-target-actor-list.js:200:12
[task 2020-03-09T12:59:05.328Z] 12:59:05     INFO - " {file: "resource://devtools/shared/protocol/Front.js" line: 68}]
[task 2020-03-09T12:59:05.328Z] 12:59:05     INFO - Buffered messages finished
[task 2020-03-09T12:59:05.329Z] 12:59:05     INFO - TEST-UNEXPECTED-FAIL | devtools/client/framework/test/browser_toolbox_tool_ready.js | A promise chain failed to handle a rejection: Connection closed, pending request to server0.conn12.content-process24/contentProcessTarget1, type listWorkers failed
[task 2020-03-09T12:59:05.329Z] 12:59:05     INFO - 
[task 2020-03-09T12:59:05.329Z] 12:59:05     INFO - Request stack:
[task 2020-03-09T12:59:05.329Z] 12:59:05     INFO - request@resource://devtools/shared/protocol/Front.js:232:14
[task 2020-03-09T12:59:05.329Z] 12:59:05     INFO - generateRequestMethods/</frontProto[name]@resource://devtools/shared/protocol/Front/FrontClassWithSpec.js:47:19
[task 2020-03-09T12:59:05.329Z] 12:59:05     INFO - listAllWorkerTargets@resource://devtools/shared/fronts/root.js:183:38
[task 2020-03-09T12:59:05.329Z] 12:59:05     INFO - async*listAllServiceWorkers@resource://devtools/shared/fronts/root.js:75:20
[task 2020-03-09T12:59:05.329Z] 12:59:05     INFO - async*updateWorkers@resource://devtools/client/application/initializer.js:102:65
[task 2020-03-09T12:59:05.329Z] 12:59:05     INFO - _emit@resource://devtools/shared/event-emitter.js:226:34
[task 2020-03-09T12:59:05.330Z] 12:59:05     INFO - emit@resource://devtools/shared/event-emitter.js:172:18
[task 2020-03-09T12:59:05.330Z] 12:59:05     INFO - emit@resource://devtools/shared/event-emitter.js:324:18
[task 2020-03-09T12:59:05.330Z] 12:59:05     INFO - onPacket@resource://devtools/shared/protocol/Front.js:270:13
[task 2020-03-09T12:59:05.330Z] 12:59:05     INFO - onPacket@resource://devtools/shared/client/devtools-client.js:498:13
[task 2020-03-09T12:59:05.330Z] 12:59:05     INFO - send/<@resource://devtools/shared/transport/local-transport.js:68:25
[task 2020-03-09T12:59:05.330Z] 12:59:05     INFO - exports.makeInfallible/<@resource://devtools/shared/ThreadSafeDevToolsUtils.js:111:22
[task 2020-03-09T12:59:05.330Z] 12:59:05     INFO - DevToolsUtils.executeSoon*exports.executeSoon@resource://devtools/shared/DevToolsUtils.js:62:21
[task 2020-03-09T12:59:05.330Z] 12:59:05     INFO - send@resource://devtools/shared/transport/local-transport.js:56:21
[task 2020-03-09T12:59:05.331Z] 12:59:05     INFO - send@resource://devtools/server/devtools-server-connection.js:91:20
[task 2020-03-09T12:59:05.331Z] 12:59:05     INFO - onWorkerListChanged@resource://devtools/server/actors/root.js:475:15
[task 2020-03-09T12:59:05.339Z] 12:59:05     INFO - _notifyListChanged@resource://devtools/server/actors/worker/worker-target-actor-list.js:184:10
[task 2020-03-09T12:59:05.339Z] 12:59:05     INFO - onUnregister@resource://devtools/server/actors/worker/worker-target-actor-list.js:200:12
[task 2020-03-09T12:59:05.339Z] 12:59:05     INFO -  - stack: destroy@resource://devtools/shared/protocol/Front.js:68:23
[task 2020-03-09T12:59:05.339Z] 12:59:05     INFO - _destroyTarget@resource://devtools/shared/fronts/targets/target-mixin.js:471:13
[task 2020-03-09T12:59:05.340Z] 12:59:05     INFO - destroy@resource://devtools/shared/fronts/targets/target-mixin.js:425:12
[task 2020-03-09T12:59:05.340Z] 12:59:05     INFO - _emit@resource://devtools/shared/event-emitter.js:226:34
[task 2020-03-09T12:59:05.340Z] 12:59:05     INFO - emit@resource://devtools/shared/event-emitter.js:172:18
[task 2020-03-09T12:59:05.340Z] 12:59:05     INFO - emit@resource://devtools/shared/event-emitter.js:324:18
[task 2020-03-09T12:59:05.340Z] 12:59:05     INFO - onClosed@resource://devtools/shared/client/devtools-client.js:612:10
[task 2020-03-09T12:59:05.340Z] 12:59:05     INFO - close@resource://devtools/shared/transport/local-transport.js:169:20
[task 2020-03-09T12:59:05.340Z] 12:59:05     INFO - close@resource://devtools/shared/transport/local-transport.js:165:13
[task 2020-03-09T12:59:05.340Z] 12:59:05     INFO - close@resource://devtools/shared/transport/local-transport.js:165:13
[task 2020-03-09T12:59:05.340Z] 12:59:05     INFO - cleanup@resource://devtools/shared/client/devtools-client.js:129:27
[task 2020-03-09T12:59:05.340Z] 12:59:05     INFO - close/promise<@resource://devtools/shared/client/devtools-client.js:145:7
[task 2020-03-09T12:59:05.340Z] 12:59:05     INFO - close@resource://devtools/shared/client/devtools-client.js:122:21
[task 2020-03-09T12:59:05.340Z] 12:59:05     INFO - _destroyTarget@resource://devtools/shared/fronts/targets/target-mixin.js:449:30
[task 2020-03-09T12:59:05.340Z] 12:59:05     INFO - destroy@resource://devtools/shared/fronts/targets/target-mixin.js:425:12
[task 2020-03-09T12:59:05.340Z] 12:59:05     INFO - destroy@resource://devtools/shared/fronts/targets/browsing-context.js:154:27
[task 2020-03-09T12:59:05.340Z] 12:59:05     INFO - _destroyToolbox/onceDestroyed</<@resource://devtools/client/framework/toolbox.js:3747:32
[task 2020-03-09T12:59:05.340Z] 12:59:05     INFO - promise callback*_destroyToolbox/onceDestroyed<@resource://devtools/client/framework/toolbox.js:3712:12
[task 2020-03-09T12:59:05.340Z] 12:59:05     INFO - _destroyToolbox@resource://devtools/client/framework/toolbox.js:3708:27
[task 2020-03-09T12:59:05.340Z] 12:59:05     INFO - destroy@resource://devtools/client/framework/toolbox.js:3583:10
[task 2020-03-09T12:59:05.340Z] 12:59:05     INFO - performChecks/<@chrome://mochitests/content/browser/devtools/client/framework/test/browser_toolbox_tool_ready.js:28:19
[task 2020-03-09T12:59:05.340Z] 12:59:05     INFO - async*performChecks@chrome://mochitests/content/browser/devtools/client/framework/test/browser_toolbox_tool_ready.js:29:5
[task 2020-03-09T12:59:05.340Z] 12:59:05     INFO - test/<@chrome://mochitests/content/browser/devtools/client/framework/test/browser_toolbox_tool_ready.js:37:11
[task 2020-03-09T12:59:05.340Z] 12:59:05     INFO - async*test@chrome://mochitests/content/browser/devtools/client/framework/test/browser_toolbox_tool_ready.js:41:5
[task 2020-03-09T12:59:05.340Z] 12:59:05     INFO - Tester_execTest@chrome://mochikit/content/browser-test.js:1099:15
[task 2020-03-09T12:59:05.340Z] 12:59:05     INFO - nextTest/<@chrome://mochikit/content/browser-test.js:925:14
[task 2020-03-09T12:59:05.340Z] 12:59:05     INFO - SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:918:23
[task 2020-03-09T12:59:05.340Z] 12:59:05     INFO - Rejection date: Mon Mar 09 2020 12:59:05 GMT+0000 (Coordinated Universal Time) - false == true - JS frame :: resource://testing-common/PromiseTestUtils.jsm :: assertNoUncaughtRejections :: line 265
[task 2020-03-09T12:59:05.340Z] 12:59:05     INFO - Stack trace:
[task 2020-03-09T12:59:05.340Z] 12:59:05     INFO - resource://testing-common/PromiseTestUtils.jsm:assertNoUncaughtRejections:265
[task 2020-03-09T12:59:05.340Z] 12:59:05     INFO - chrome://mochikit/content/browser-test.js:nextTest:624
[task 2020-03-09T12:59:05.340Z] 12:59:05     INFO - chrome://mochikit/content/browser-test.js:testScope/test_finish/<:1457
[task 2020-03-09T12:59:05.340Z] 12:59:05     INFO - chrome://mochikit/content/browser-test.js:run:1372
[task 2020-03-09T12:59:05.340Z] 12:59:05     INFO - GECKO(1855) | MEMORY STAT | vsize 20976277MB | residentFast 2300MB
[task 2020-03-09T12:59:05.340Z] 12:59:05     INFO - TEST-OK | devtools/client/framework/test/browser_toolbox_tool_ready.js | took 21677ms
[task 2020-03-09T12:59:05.341Z] 12:59:05     INFO - checking window state
Summary: Intermittent devtools/client/framework/test/browser_toolbox_tool_ready.js | A promise chain failed to handle a rejection: Connection closed, pending request to server0.conn12.content-process24/contentProcessTarget1, type listWorkers failed → Intermittent devtools/client/framework/test/*.js | A promise chain failed to handle a rejection: Connection closed, pending request to <path>, type listWorkers failed

This fails very frequently. Alexandre, any recommendations on the next step here?

Flags: needinfo?(poirot.alex)

This may relate to bug 1603190.
A few bugs got fixed in bug 1633703, but that may not have been enough.

Julian, could you confirm if that relates to windowless service worker?

I'm wondering if bug 1603190 is really worth all the time spent. We aren't only sparing DevTools engineer's time here, but also sherrifs's one.
If that's the case, we should report all the time spent trying to debug this known to be bad feature.
And possibly revisit the decision to enable this.

Flags: needinfo?(poirot.alex) → needinfo?(jdescottes)

It's very likely related to the same issue. We could disable dom.ipc.processPrelaunch.enabled in more tests I guess.
Will look more tomorrow.

Julian are there updates here?

Flags: needinfo?(jdescottes)
Whiteboard: [stockwell disable-recommended] → [stockwell needswork:owner]
Flags: needinfo?(jdescottes)

I'll try to see how many tests are opening the debugger without setting dom.ipc.processPrelaunch.enabled to false. Looking at the duplicates here, not all failures seem to be in devtools/client/framework/test/ so we can't simply flip the preference for the framework/test/browser.ini suite.

Each debugger test without the pref should fail in https://treeherder.mozilla.org/#/jobs?repo=try&revision=eb5917ec43bdfab987fc8e83a0c722a99f609a99, after that we can see if we flip the pref individually on each test or do something different.

Keeping the ni.

According to the test above, we have 56 tests which open the debugger without flipping the preference:

devtools/client/inspector/markup/test/browser_markup_links_06.js
devtools/client/inspector/markup/test/browser_markup_shadowdom_open_debugger.js
devtools/client/inspector/markup/test/browser_markup_shadowdom_open_debugger_pretty_printed.js
devtools/client/inspector/markup/test/browser_markup_view-original-source.js
devtools/client/inspector/markup/test/browser_markup_view-source.js
devtools/client/inspector/test/browser_inspector_destroy-before-ready.js
devtools/client/inspector/test/browser_inspector_highlighter-07.js
devtools/client/aboutdebugging/test/browser/browser_aboutdebugging_addons_debug_debugger.js
devtools/client/aboutdebugging/test/browser/browser_aboutdebugging_devtoolstoolbox_reload.js
devtools/client/webconsole/test/browser/browser_webconsole_click_function_to_mapped_source.js
devtools/client/webconsole/test/browser/browser_webconsole_click_function_to_prettyprinted_source.js
devtools/client/webconsole/test/browser/browser_webconsole_click_function_to_source.js
devtools/client/webconsole/test/browser/browser_webconsole_eval_in_debugger_stackframe.js
devtools/client/webconsole/test/browser/browser_webconsole_eval_sources.js
devtools/client/webconsole/test/browser/browser_webconsole_location_debugger_link.js
devtools/client/webconsole/test/browser/browser_webconsole_location_logpoint_debugger_link.js
devtools/client/webconsole/test/browser/browser_webconsole_object_inspector_while_debugging_and_inspecting.js
devtools/client/webconsole/test/browser/browser_webconsole_optimized_out_vars.js
devtools/client/webconsole/test/browser/browser_webconsole_sourcemap_nosource.js
devtools/client/webconsole/test/browser/browser_webconsole_split.js
devtools/client/webconsole/test/browser/browser_webconsole_stacktrace_location_debugger_link.js
devtools/client/webconsole/test/browser/browser_webconsole_stacktrace_mapped_location_debugger_link.js
devtools/client/webconsole/test/browser/browser_webconsole_view_source.js
devtools/client/webconsole/test/browser/browser_webconsole_worker_evaluate.js
devtools/client/netmonitor/test/browser_net_open_in_debugger.js
devtools/client/netmonitor/test/browser_net_view-source-debugger.js
devtools/client/shared/test/browser_dbg_worker-console-02.js
devtools/client/shared/test/browser_dbg_worker-console-03.js
devtools/client/shared/test/browser_dbg_worker-console-04.js
devtools/client/shared/test/browser_telemetry_toolboxtabs_jsdebugger.js
devtools/client/webconsole/test/browser/browser_jsterm_autocomplete_in_debugger_stackframe.js
devtools/client/webconsole/test/browser/browser_jsterm_await_paused.js
devtools/client/webconsole/test/browser/browser_jsterm_eager_evaluation_in_debugger_stackframe.js
devtools/client/webconsole/test/browser/browser_jsterm_eager_evaluation_on_webextension_target.js
devtools/client/webconsole/test/browser/browser_jsterm_inspect_panels.js
devtools/client/framework/test/browser_keybindings_01.js
devtools/client/framework/test/browser_new_activation_workflow.js
devtools/client/framework/test/browser_source_map-01.js
devtools/client/framework/test/browser_source_map-absolute.js
devtools/client/framework/test/browser_source_map-init.js
devtools/client/framework/test/browser_source_map-inline.js
devtools/client/framework/test/browser_source_map-pub-sub.js
devtools/client/framework/test/browser_toolbox_getpanelwhenready.js
devtools/client/framework/test/browser_toolbox_highlight.js
devtools/client/framework/test/browser_toolbox_split_console.js
devtools/client/framework/test/browser_toolbox_tabsswitch_shortcuts.js
devtools/client/framework/test/browser_toolbox_telemetry_enter.js
devtools/client/framework/test/browser_toolbox_telemetry_exit.js
devtools/client/framework/test/browser_toolbox_tool_ready.js
devtools/client/framework/test/browser_toolbox_tool_remote_reopen.js
devtools/client/framework/test/browser_toolbox_view_source_01.js
devtools/client/framework/test/browser_toolbox_view_source_02.js
devtools/client/framework/test/browser_toolbox_view_source_03.js
devtools/client/framework/test/browser_toolbox_window_reload_target.js
devtools/client/framework/test/browser_toolbox_window_shortcuts.js
devtools/client/framework/test/browser_toolbox_window_title_changes.js
Assignee: nobody → jdescottes
Status: NEW → ASSIGNED
See Also: → 1637134
Attachment #9147192 - Attachment description: Bug 1620983 - Disable dom.ipc.processPrelaunch.enabled for all devtools tests using the debugger → Bug 1620983 - Disable dom.ipc.processPrelaunch.enabled for all devtools tests
Pushed by jdescottes@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/1e0e5abd36b7 Disable dom.ipc.processPrelaunch.enabled for all devtools tests r=ochameau
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 78

It still seems to fail pretty frequently.

The situation might improve with Bug 1621337 for some tests.
For instance I could see that browser_metrics_debugger.js was fixed with my patches from Bug 1621337, because the debugger now properly waits for service workers when initializing.

Flags: needinfo?(jdescottes)
See Also: → 1621337
See Also: → 1637793

This is still failing. Low occurrency , but still fails.
Recent log link: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=306925807&repo=autoland&lineNumber=8558

Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Target Milestone: Firefox 78 → ---
Whiteboard: [stockwell disable-recommended]

The new failures are tracked in this bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1637793

Target Milestone: --- → Firefox 78
Status: REOPENED → RESOLVED
Closed: 5 years ago5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: