1621337 - Expose Service Workers for tab targets in the TargetList

Status: RESOLVED FIXED

(DevTools :: Debugger, enhancement, P2)

Description

[Alexandre Poirot [:ochameau]]

Bug 1594754 started exposing service workers when the TargetList was attached to a Parent Process Targets. i.e. the browser toolbox codepath.
But with the windowless service worker features, the Debugger panel expects to also be able to retrieve the service workers of the page that the content toolbox is debugging.
We would need to tweak the TargetList once again in order to enable to notify about the service worker targets related to the page, that, behind a preference as it has some significant impact on the performance.

Comment 1

[Chris Peterson [:cpeterson]]

Tracking Fission DevTools bugs for Fission Nightly (M6) milestone

Comment 2

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1621337 - wip service worker registrations

Comment 3

[Alexandre Poirot [:ochameau]]

Note that the immediate goal is to unlock the debugger to use the TargetList for all its targets (bug 1626655).
So we probably don't have to expose all what RootFront.listAllWorkers currently exposes.

Comment 5

[Julian Descottes [:jdescottes]]

Attachment: Bug 1621337 - Naive support for service workers in target-list

Depends on D73803

Comment 6

[Julian Descottes [:jdescottes]]

Attachment: Bug 1621337 - Get the target list support for service workers closer to current expectations

Depends on D74056

Comment 7

[Julian Descottes [:jdescottes]]

Attachment: Bug 1621337 - Use target list for service workers in debugger

Depends on D74057

Comment 8

[Julian Descottes [:jdescottes]]

Attachment: Bug 1621337 - Do not update toolbox target listeners for service workers (WIP)

Depends on D74059

Comment 9

[Julian Descottes [:jdescottes]]

Attachment: Bug 1621337 - Check if existingTargets is still defined when processing listWorkerChanged

Depends on D74419

Comment 10

[Julian Descottes [:jdescottes]]

Attachment: Bug 1621337 - Add support for service workers in target-list

Depends on D74699

Comment 11

[Julian Descottes [:jdescottes]]

Attachment: Bug 1621337 - Add an option to workers listener to only listen to sw registrations

Depends on D74700

Comment 12

[Julian Descottes [:jdescottes]]

Attachment: Bug 1621337 - Enable service worker target listening in the debugger

Depends on D74701

Only for reference, this might not land

Comment 14

[Chris Peterson [:cpeterson]]

Tracking dt-fission-m2-mvp bugs for Fission Nightly milestone (M6c)

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6dc7f0528d29
Check if existingTargets is still defined when processing listWorkerChanged r=ochameau
https://hg.mozilla.org/integration/autoland/rev/0680f7d982e1
Add an option to workers listener to only listen to sw registrations r=ochameau
https://hg.mozilla.org/integration/autoland/rev/1b9b798b261e
Add support for service workers in target-list r=ochameau

Comment 17

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/6dc7f0528d29
https://hg.mozilla.org/mozilla-central/rev/0680f7d982e1
https://hg.mozilla.org/mozilla-central/rev/1b9b798b261e