1620997 - Improve IC support for JSOp::Pow

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, task, P3)

Description

[Jan de Mooij [:jandem]]

Unlike IonBuilder, WarpBuilder will fall back to an IC for JSOp::Pow so we need to make sure we have CacheIR support for the most interesting cases. This will also make JSOp::Pow in Baseline faster.

Comment 1

[André Bargull [:anba]]

I'll try to look into this one. (I may end up dup'ing it to bug 1188079.)

Comment 2

[André Bargull [:anba]]

Ugh, I can't land all of bug 1188079 (specifically part 3 shouldn't yet land), because it also requires bug 1564942.

Comment 3

[André Bargull [:anba]]

Attachment: Bug 1620997 - Part 1: Add `pow32` to the MacroAssembler. r=jandem!

This is an inline implementation of js::powi.

Comment 4

[André Bargull [:anba]]

Attachment: Bug 1620997 - Part 2: Add JSOp::Pow support to CacheIR. r=jandem!

There are too few registers available on x86, so the code tries to reuse the output
operand's type register in addition to its payload register.

Comment 5

[André Bargull [:anba]]

Attachment: Bug 1620997 - Part 3: Add Ion IC support for JSOp::Pow. r=jandem!

Comment 6

[André Bargull [:anba]]

Attachment: Bug 1620997 - Part 4: Remove no longer used non-number MPow specialisation. r=jandem!

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/815e8172ee57
Part 1: Add `pow32` to the MacroAssembler. r=jandem
https://hg.mozilla.org/integration/autoland/rev/fbbb339d3fdb
Part 2: Add JSOp::Pow support to CacheIR. r=jandem
https://hg.mozilla.org/integration/autoland/rev/9de84bcc6696
Part 3: Add Ion IC support for JSOp::Pow. r=jandem
https://hg.mozilla.org/integration/autoland/rev/0a8e055cf0ad
Part 4: Remove no longer used non-number MPow specialisation. r=jandem

Comment 8

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/815e8172ee57
https://hg.mozilla.org/mozilla-central/rev/fbbb339d3fdb
https://hg.mozilla.org/mozilla-central/rev/9de84bcc6696
https://hg.mozilla.org/mozilla-central/rev/0a8e055cf0ad