Improve IC support for JSOp::Pow
Categories
(Core :: JavaScript Engine: JIT, task, P3)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox77 | --- | fixed |
People
(Reporter: jandem, Assigned: anba)
References
(Blocks 1 open bug)
Details
Attachments
(4 files)
Unlike IonBuilder, WarpBuilder will fall back to an IC for JSOp::Pow so we need to make sure we have CacheIR support for the most interesting cases. This will also make JSOp::Pow in Baseline faster.
|
||
Updated•4 years ago
|
|
Assignee | |
Comment 1•4 years ago
|
||
I'll try to look into this one. (I may end up dup'ing it to bug 1188079.)
|
|
Assignee | |
Comment 2•4 years ago
|
||
Ugh, I can't land all of bug 1188079 (specifically part 3 shouldn't yet land), because it also requires bug 1564942.
|
|
Assignee | |
Comment 3•4 years ago
|
||
This is an inline implementation of js::powi.
|
|
Assignee | |
Comment 4•4 years ago
|
||
There are too few registers available on x86, so the code tries to reuse the output
operand's type register in addition to its payload register.
|
|
Assignee | |
Comment 5•4 years ago
|
||
|
|
Assignee | |
Comment 6•4 years ago
|
||
Pushed by rgurzau@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/815e8172ee57 Part 1: Add `pow32` to the MacroAssembler. r=jandem https://hg.mozilla.org/integration/autoland/rev/fbbb339d3fdb Part 2: Add JSOp::Pow support to CacheIR. r=jandem https://hg.mozilla.org/integration/autoland/rev/9de84bcc6696 Part 3: Add Ion IC support for JSOp::Pow. r=jandem https://hg.mozilla.org/integration/autoland/rev/0a8e055cf0ad Part 4: Remove no longer used non-number MPow specialisation. r=jandem
|
||
Comment 8•4 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/815e8172ee57
https://hg.mozilla.org/mozilla-central/rev/fbbb339d3fdb
https://hg.mozilla.org/mozilla-central/rev/9de84bcc6696
https://hg.mozilla.org/mozilla-central/rev/0a8e055cf0ad
Description
•