1621031 - The “Collection Promo” section is wrongly redisplayed on the first opened new tab after being dismissed using the “Delete from Pocket”/”Archive in Pocket” options

Status: RESOLVED WONTFIX

(Firefox :: New Tab Page, defect, P4)

Description

[Maria Heres, inactive, contact Ecosystem QA]

Attachment: new tab dismiss failure.gif

[Affected Versions]:

• Firefox Nightly 75.0a1 Build ID: 20200309091841

[Affected Platforms]:

• Windows 10 x64
• macOS 10.15
• Linux Mint 19.2 Tina

[Prerequisites]:

• Have the value of the pref browser.newtabpage.activity-stream.discoverystream.spocs-endpoint set to https://spocs.getpocket.com/spocs?site=1116390&country=US&region=US-CA.
• Have the value of the pref browser.search.region set to US.
• Be logged into Pocket.

[Steps to reproduce]:

1. Open the browser with the profile from prerequisites and open a new tab.
2. Click the “Open menu” button of a Collection card and select the “Save to Pocket” option.
3. For the same card, click the “Open menu” button and select the “Delete from Pocket” option.
4. Repeat steps 2 and 3 for three more cards to dismiss the section.
5. Open a new tab and observe the behavior.

[Expected results]:

• The “Collections Promo” section is no longer displayed.

[Actual results]:

• The “Collections Promo” section is redisplayed.

[Notes]:

• This issue is also reproducible if using “Archive in Pocket” instead of “Delete from Pocket” in the steps above.
• The section is dismissed after opening another new tab.
• This issue is not reproducible if the “Dismiss” option of a card is used instead.
• This issue is not reproducible if the section is dismissed from the section “Dismiss” button.
• The browser.newtabpage.activity-stream.discoverystream.isCollectionDismissible pref does not affect the results for either of its values.
• Possibly caused by Bug 1621023.
• Attached is a recording of the issue.

Comment 1

[Scott [:thecount] Downe]

This is happening because the archive/save then delete actions don't update the preloaded tab.

They could, but I suspect this is something we can live with for the experiment.

@tawanda is that true, can we live with this for the experiment?

Comment 2

[Scott [:thecount] Downe]

Also, to re test this, you can enable newtab devtools, then go about:newtab#devtools-ds and click "refresh cache" and the collection comes back to be tested again.

Comment 3

[Scott [:thecount] Downe]

Also probably worth noting, I'm pretty sure I was reproducing this on regular stories, and not just collections.

Comment 4

[Tawanda Kanhema]

We're good to launch the experiment with this behavior. We can pick this up as part of a bigger bucket of dismiss/delete function work. :thecount :maria.heres

Comment 5

[Maria Heres, inactive, contact Ecosystem QA]

@Scott, I have tested the scenario mentioned in comment 3 and I can confirm the normal and SPOC stories from the “Recommended by Pocket” section are also redisplayed in a new tab after being dismissed using “Delete from Pocket” and “Archive in Pocket”.

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

Bugbug thinks this bug is a regression, but please revert this change in case of error.

Comment 7

[Jens Stutte [:jstutte]]

(In reply to Tawanda Kanhema from comment #4)

We're good to launch the experiment with this behavior. We can pick this up as part of a bigger bucket of dismiss/delete function work. :thecount :maria.heres

Should we adjust then priority/severity for this bug?

Comment 8

[Firefox Bug Husbandry Bot]

Updating Severity from minor to P4 per May 4th changes to Severity field and triage process.

Comment 9

[BugBot [:suhaib / :marco/ :calixte]]

Redirect a needinfo that is pending on an inactive user to the triage owner.
:daleharvey, since the bug has high priority, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 10

[Scott [:thecount] Downe]

I'm just going to wont-fix this.

Collection promos are a currently not running feature, and the user impact of this bug is minimal anyway even if it were running.