Closed Bug 1621191 Opened 5 years ago Closed 5 years ago

Intermittent toolkit/components/passwordmgr/test/browser/browser_doorhanger_generated_password.js | Uncaught exception - at chrome://mochitests/content/browser/toolkit/components/passwordmgr/test/browser/browser_doorhanger_generated_password.js:100 - Type

Categories

(Toolkit :: Password Manager, defect, P1)

defect

Tracking

()

RESOLVED FIXED

People

(Reporter: intermittent-bug-filer, Assigned: sfoster)

References

(Regression)

Details

(Keywords: intermittent-failure, regression, Whiteboard: [retriggered][stockwell unknown])

Filed by: nbeleuzu [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer.html#?job_id=292377490&repo=autoland
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/HKyE3hdcS8uCuUKuBr9yBA/runs/0/artifacts/public/logs/live_backing.log


[task 2020-03-10T01:34:08.655Z] 01:34:08 INFO - TEST-PASS | toolkit/components/passwordmgr/test/browser/browser_doorhanger_generated_password.js | autocomplete popup shown -
[task 2020-03-10T01:34:08.656Z] 01:34:08 INFO - Clicking the generated password AC item
[task 2020-03-10T01:34:08.658Z] 01:34:08 INFO - Waiting for the content input value to change
[task 2020-03-10T01:34:08.659Z] 01:34:08 INFO - listenForTestNotification, resolving for message: PasswordEditedOrGenerated
[task 2020-03-10T01:34:08.660Z] 01:34:08 INFO - Buffered messages logged at 01:34:08
[task 2020-03-10T01:34:08.661Z] 01:34:08 INFO - Waiting for the passwordGeneratedPromise
[task 2020-03-10T01:34:08.666Z] 01:34:08 INFO - waiting for dismissed password-change notification
[task 2020-03-10T01:34:08.667Z] 01:34:08 INFO - verifyConfirmationHint
[task 2020-03-10T01:34:08.667Z] 01:34:08 INFO - verifyConfirmationHint, hintPromiseShown resolved
[task 2020-03-10T01:34:08.668Z] 01:34:08 INFO - Buffered messages finished
[task 2020-03-10T01:34:08.670Z] 01:34:08 INFO - TEST-UNEXPECTED-FAIL | toolkit/components/passwordmgr/test/browser/browser_doorhanger_generated_password.js | Uncaught exception - at chrome://mochitests/content/browser/toolkit/components/passwordmgr/test/browser/browser_doorhanger_generated_password.js:100 - TypeError: can't access property "id", hintElem.anchorNode is null
[task 2020-03-10T01:34:08.670Z] 01:34:08 INFO - Stack trace:
[task 2020-03-10T01:34:08.670Z] 01:34:08 INFO - verifyConfirmationHint@chrome://mochitests/content/browser/toolkit/components/passwordmgr/test/browser/browser_doorhanger_generated_password.js:100:1
[task 2020-03-10T01:34:08.670Z] 01:34:08 INFO - taskFn@chrome://mochitests/content/browser/toolkit/components/passwordmgr/test/browser/browser_doorhanger_generated_password.js:1365:13
[task 2020-03-10T01:34:08.670Z] 01:34:08 INFO - asyncopenFormInNewTab/<@chrome://mochitests/content/browser/toolkit/components/passwordmgr/test/browser/browser_doorhanger_generated_password.js:193:13
[task 2020-03-10T01:34:08.671Z] 01:34:08 INFO - async
withNewTab@resource://testing-common/BrowserTestUtils.jsm:150:24
[task 2020-03-10T01:34:08.671Z] 01:34:08 INFO - asyncopenFormInNewTab@chrome://mochitests/content/browser/toolkit/components/passwordmgr/test/browser/browser_doorhanger_generated_password.js:112:26
[task 2020-03-10T01:34:08.671Z] 01:34:08 INFO - form_change_from_autosaved_login_to_existing_login@chrome://mochitests/content/browser/toolkit/components/passwordmgr/test/browser/browser_doorhanger_generated_password.js:1327:9
[task 2020-03-10T01:34:08.671Z] 01:34:08 INFO - Async
Tester_execTest/<@chrome://mochikit/content/browser-test.js:1062:34
[task 2020-03-10T01:34:08.671Z] 01:34:08 INFO - async*Tester_execTest@chrome://mochikit/content/browser-test.js:1097:11
[task 2020-03-10T01:34:08.671Z] 01:34:08 INFO - nextTest/<@chrome://mochikit/content/browser-test.js:925:14
[task 2020-03-10T01:34:08.672Z] 01:34:08 INFO - SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:918:23
[task 2020-03-10T01:34:08.672Z] 01:34:08 INFO - Leaving test bound form_change_from_autosaved_login_to_existing_login
[task 2020-03-10T01:34:08.672Z] 01:34:08 INFO - GECKO(6595) | MEMORY STAT | vsize 3388MB | residentFast 394MB | heapAllocated 124MB

Has Regression Range: --- → yes
Keywords: regression
Assignee: nobody → sfoster
Status: NEW → ASSIGNED
Priority: P5 → P1
Whiteboard: [retriggered] → [retriggered][stockwell needswork:owner]

A found a few cases where the hint popup might be lingering between tests so overlapping popuphidden events might get us into a confusing state where we attempt to verify a confirmation hint when the browser should be attached to (its anchorNode) has gone away. We also don't need to wait for the hint to self-close each time, so this test should run a bit faster now.

But that's still not fixing the underlying problem apparently: https://treeherder.mozilla.org/#/jobs?repo=try&revision=aee3bd7a56b4f642691361c2f6586cd8bba8c8f8&selectedJob=292768331

So I'm still investigating.

Fixed by the backout in Comment 7. I'll address and re-land this from bug 1618696.

Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.