Closed Bug 1618696 Opened 5 years ago Closed 5 years ago

Enable signon.passwordEditCapture.enabled to create a dismissed doorhanger when a password field value is edited

Categories

(Toolkit :: Password Manager, enhancement, P1)

Product:
Toolkit
Component:
Password Manager
Type:
enhancement

Tracking

()

Status:
VERIFIED FIXED
Milestone:
mozilla76
Tracking Flags:
Tracking Status
firefox76 --- verified

People

(Reporter: sfoster, Assigned: sfoster)

References

Details

(Whiteboard: [passwords:capture-UI])

Attachments

(2 files)

Bug 1618696 - Enable signon.passwordEditCapture.enabled by default. r?MattN
47 bytes, text/x-phabricator-request
Details | Review
Bug 1618696 - Prevent overlapping show/hide of the ConfirmationHint. r?MattN
47 bytes, text/x-phabricator-request
Details | Review

The pref signon.passwordEditCapture.enabled defaults to false since landing in bug 1536728.
Defaulting to true will enable the feature to "Show a dismissed login capture doorhanger when a user edits a password field (before submission)"

Assignee: nobody → sfoster
Status: NEW → ASSIGNED
Pushed by sfoster@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/d88fa0632596 Enable signon.passwordEditCapture.enabled by default. r=MattN

Backed out for failures on browser_doorhanger_dismissed_for_ccnumber.js

backout: https://hg.mozilla.org/integration/autoland/rev/569c2e34f9dfeafaf72339988bcc5ec7a3152002

push: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=d88fa063259632700b8606663871a2d2f2514075&searchStr=os%2Cx%2C10.14%2Cdebug%2Cmochitests%2Ctest-macosx1014-64%2Fdebug-mochitest-browser-chrome-e10s-2%2Cm%28bc2%29&group_state=expanded&selectedJob=291206616

failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=291206616&repo=autoland&lineNumber=18158

[task 2020-03-02T02:52:22.113Z] 02:52:22 INFO - Waiting for passwordFilledPromise
[task 2020-03-02T02:52:22.113Z] 02:52:22 INFO - Waiting for FormSubmit
[task 2020-03-02T02:52:22.113Z] 02:52:22 INFO - Buffered messages finished
[task 2020-03-02T02:52:22.113Z] 02:52:22 INFO - TEST-UNEXPECTED-FAIL | toolkit/components/passwordmgr/test/browser/browser_doorhanger_dismissed_for_ccnumber.js | Test timed out -
[task 2020-03-02T02:52:22.113Z] 02:52:22 INFO - GECKO(2161) | MEMORY STAT | vsize 7649MB | residentFast 377MB | heapAllocated 113MB
[task 2020-03-02T02:52:22.113Z] 02:52:22 INFO - TEST-OK | toolkit/components/passwordmgr/test/browser/browser_doorhanger_dismissed_for_ccnumber.js | took 90169ms
[task 2020-03-02T02:52:22.113Z] 02:52:22 INFO - Not taking screenshot here: see the one that was previously logged
[task 2020-03-02T02:52:22.113Z] 02:52:22 INFO - TEST-UNEXPECTED-FAIL | toolkit/components/passwordmgr/test/browser/browser_doorhanger_dismissed_for_ccnumber.js | Found a tab after previous test timed out: https://example.com/browser/toolkit/components/passwordmgr/test/browser/form_basic.html?username=4111111111111111&password=123 -
[task 2020-03-02T02:52:22.113Z] 02:52:22 INFO - GECKO(2161) | [Child 2166: Main Thread]: I/DocShellAndDOMWindowLeak ++DOCSHELL 0x10cf44800 == 1 [pid = 2166] [id = {98fc22e0-cfd2-a14a-9974-4a69b6bbf630}]
[task 2020-03-02T02:52:22.113Z] 02:52:22 INFO - GECKO(2161) | [Child 2166: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 1 (0x10cf0bc60) [pid = 2166] [serial = 81] [outer = 0x0]
[task 2020-03-02T02:52:22.113Z] 02:52:22 INFO - GECKO(2161) | [Child 2166, Main Thread] WARNING: NS_ENSURE_TRUE(mPresShell) failed: file /builds/worker/workspace/build/src/layout/base/nsPresContext.cpp, line 848
[task 2020-03-02T02:52:22.113Z] 02:52:22 INFO - GECKO(2161) | [Child 2166: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 2 (0x10d818400) [pid = 2166] [serial = 82] [outer = 0x10cf0bc60]
[task 2020-03-02T02:52:22.118Z] 02:52:22 INFO - checking window state

Flags: needinfo?(sfoster)

thanks for the backout. I'm working on fixing these tests.

Flags: needinfo?(sfoster)
Pushed by sfoster@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/bdc7b2a874ac Enable signon.passwordEditCapture.enabled by default. r=MattN

This isn't a perma failure, however this intermittent started from your push. If needed we will reland it.

We do want this in before the soft freeze if possible.
I have some improvements to this test running at https://treeherder.mozilla.org/#/jobs?repo=try&revision=8d0139650e57a21d020f40f467cc6e97e1c240a3
try fuzzy is estimating 2-3hrs for those tests to run. Would it make sense for you to re-land and I'll land the test improvements ASAP (in the morning if they look good.) ?

Flags: needinfo?(sfoster) → needinfo?(aciure)

(In reply to Sam Foster [:sfoster] (he/him) from comment #8)

I'll land the test improvements ASAP (in the morning if they look good.) ?

I would break them out into the own follow-up bug + patch.

Since it has a fairly high fail rate, I think it would be best if you pinged me on riot when those test runs go green. I'l reland and you can follow up with the patch. Is that ok?

Flags: needinfo?(aciure) → needinfo?(sfoster)

Sam, it looks like the failures were only on ASAN so far so rs=me on skip-if = asan

Pushed by mozilla@noorenberghe.ca: https://hg.mozilla.org/integration/autoland/rev/717735305b7c Enable signon.passwordEditCapture.enabled by default. r=MattN

I've split this patch into 2 now. Enabling the pref will wait until the merge. The test and defect fixes are up for review on bug 1620482.

Flags: needinfo?(sfoster)
Pushed by sfoster@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/cc4ec8298e52 Enable signon.passwordEditCapture.enabled by default. r=MattN

https://hg.mozilla.org/mozilla-central/rev/cc4ec8298e52

Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox76: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla76
Regressions: 1621191
Regressions: 1565363

Backed out for causing bug 1621191 and 1565363

Backout: https://hg.mozilla.org/integration/autoland/rev/026b396d278821202955c5a422723c09df428e54

Status: RESOLVED → REOPENED
status-firefox76: fixed → ---
Flags: needinfo?(sfoster)
Resolution: FIXED → ---
Target Milestone: mozilla76 → ---

Working on it, thanks :aryx.

Flags: needinfo?(sfoster)
  • Track and clear a timerID for the ConfirmationHint to avoid callbacks from one show() call interfering with a subsequent call.
  • Tighten up waiting for and verifying the confirmation hint in browser_doorhanger_generated_password.js
  • Pass in the correct browser when retrieving the anchorNode for the confirmation hint.

Depends on D64843

Pushed by sfoster@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/17cebe7ee873 Enable signon.passwordEditCapture.enabled by default. r=MattN https://hg.mozilla.org/integration/autoland/rev/336f37c4efb6 Prevent overlapping show/hide of the ConfirmationHint. r=MattN

https://hg.mozilla.org/mozilla-central/rev/17cebe7ee873
https://hg.mozilla.org/mozilla-central/rev/336f37c4efb6

Status: REOPENED → RESOLVED
Closed: 5 years ago → 5 years ago
status-firefox76: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla76

Verified-fixed on Nightly 76.0a1 (2020-03-26) on Windows 10, MacOS 10.13 and Ubuntu 16.04.

  1. "signon.passwordEditCapture.enabled" is "true" by default and can confirm that the dismissed doorhanger is functional
  2. Prevent overlapping show/hide of the ConfirmationHint - is an automated test issue that doesn't need manual verification.
Status: RESOLVED → VERIFIED
status-firefox76: fixed → verified
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: