1621235 - Intermittent false ES failures - 'MailToolboxCustomizeDone' is not defined.

Status: RESOLVED FIXED

(Thunderbird :: Testing Infrastructure, defect, P5)

Description

[Treeherder Bug Filer]

Filed by: mkmelin+mozilla [at] iki.fi
Parsed log: https://treeherder.mozilla.org/logviewer.html#?job_id=292355639&repo=comm-central
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/C079YckpSKW1YaRQrRleBw/runs/0/artifacts/public/logs/live_backing.log

---

Has been happening on and off for maybe a week or so. Looks like always the same false failures:

TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/comm/calendar/base/content/calendar-command-controller.js:724:9 | 'goSetMenuValue' is not defined. (no-undef)
TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/comm/calendar/base/content/calendar-command-controller.js:727:9 | 'goSetMenuValue' is not defined. (no-undef)
TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/comm/calendar/base/content/calendar-command-controller.js:769:9 | 'PrintUtils' is not defined. (no-undef)
TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/comm/calendar/lightning/content/messenger-overlay-sidebar.js:412:5 | 'MailToolboxCustomizeDone' is not defined. (no-undef)
TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/comm/calendar/lightning/content/messenger-overlay-sidebar.js:416:5 | 'MailToolboxCustomizeDone' is not defined. (no-undef)
TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/comm/calendar/lightning/content/messenger-overlay-sidebar.js:755:24 | 'gFolderDisplay' is not defined. (no-undef)
TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/comm/calendar/lightning/content/messenger-overlay-sidebar.js:769:31 | 'InitMessageMenu' is not defined. (no-undef)
TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/comm/calendar/lightning/content/messenger-overlay-sidebar.js:770:1 | 'InitMessageMenu' is not defined. (no-undef)
TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/comm/calendar/lightning/content/messenger-overlay-sidebar.js:799:7 | 'onViewToolbarsPopupShowing' is not defined. (no-undef)
TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/comm/calendar/lightning/content/messenger-overlay-sidebar.js:801:5 | 'onViewToolbarsPopupShowing' is not defined. (no-undef)
TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/comm/calendar/lightning/content/messenger-overlay-sidebar.js:816:3 | 'onViewToolbarsPopupShowing' is not defined. (no-undef)
TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/comm/calendar/lightning/content/messenger-overlay-sidebar.js:827:5 | 'CustomizeMailToolbar' is not defined. (no-undef)
TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/comm/calendar/lightning/content/messenger-overlay-sidebar.js:908:5 | 'openAddonsMgr' is not defined. (no-undef)

Comment 1

[Magnus Melin [:mkmelin]]

Mark, did you see any random eslint failures on Firefox? Or ideas on what's going on?

Comment 2

[Magnus Melin [:mkmelin]]

Looks like first seen https://treeherder.mozilla.org/#/jobs?repo=comm-central&selectedJob=291385799&revision=ec89a721f9f9f4d7b2c9a1491364bcbd371ff512

Comment 3

[Mark Banner (:standard8)]

I wonder if this is actually the critical bit:

[task 2020-03-03T04:11:03.895Z] RangeError: Maximum call stack size exceeded
[task 2020-03-03T04:11:03.895Z] Occurred while linting /builds/worker/checkouts/gecko/comm/mail/base/content/ABSearchDialog.js:14
[task 2020-03-03T04:11:03.895Z]     at helpers.walkAST (/builds/worker/checkouts/gecko/tools/lint/eslint/eslint-plugin-mozilla/lib/globals.js:211:22)
[task 2020-03-03T04:11:03.895Z]     at Controller.enter (/builds/worker/checkouts/gecko/tools/lint/eslint/eslint-plugin-mozilla/lib/helpers.js:167:9)
[task 2020-03-03T04:11:03.895Z]     at Controller.__execute (/builds/worker/checkouts/gecko/node_modules/estraverse/estraverse.js:330:31)
[task 2020-03-03T04:11:03.895Z]     at Controller.traverse (/builds/worker/checkouts/gecko/node_modules/estraverse/estraverse.js:434:28)
[task 2020-03-03T04:11:03.895Z]     at Object.traverse (/builds/worker/checkouts/gecko/node_modules/estraverse/estraverse.js:646:27)
[task 2020-03-03T04:11:03.895Z]     at Object.walkAST (/builds/worker/checkouts/gecko/tools/lint/eslint/eslint-plugin-mozilla/lib/helpers.js:165:16)
[task 2020-03-03T04:11:03.895Z]     at Object.getGlobalsForFile (/builds/worker/checkouts/gecko/tools/lint/eslint/eslint-plugin-mozilla/lib/globals.js:208:13)
[task 2020-03-03T04:11:03.895Z]     at GlobalsForNode.Program (/builds/worker/checkouts/gecko/tools/lint/eslint/eslint-plugin-mozilla/lib/globals.js:125:47)
[task 2020-03-03T04:11:03.895Z]     at helpers.walkAST (/builds/worker/checkouts/gecko/tools/lint/eslint/eslint-plugin-mozilla/lib/globals.js:210:39)
[task 2020-03-03T04:11:03.896Z]     at Controller.enter (/builds/worker/checkouts/gecko/tools/lint/eslint/eslint-plugin-mozilla/lib/helpers.js:167:9)

I don't know if the other errors are a direct result of this, but that certainly doesn't look good. I'm not sure why this would be happening though, unless there's too many files it is having to walk through to work out the globals for them. Though I'm not sure why it wouldn't be consistently failing.

Comment 4

[Intermittent Failures Robot]

5 failures in 5336 pushes (0.001 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• comm-central: 5

Platform breakdown:

• lint: 5

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1621235&startday=2020-03-09&endday=2020-03-15&tree=all

Comment 5

[Intermittent Failures Robot]

4 failures in 4955 pushes (0.001 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• comm-central: 4

Platform breakdown:

• lint: 4

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1621235&startday=2020-03-16&endday=2020-03-22&tree=all

Comment 6

[Intermittent Failures Robot]

2 failures in 4773 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• comm-central: 2

Platform breakdown:

• lint: 2

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1621235&startday=2020-03-23&endday=2020-03-29&tree=all

Comment 7

[Intermittent Failures Robot]

4 failures in 5015 pushes (0.001 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• comm-central: 4

Platform breakdown:

• lint: 4

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1621235&startday=2020-03-30&endday=2020-04-05&tree=all

Comment 8

[Intermittent Failures Robot]

3 failures in 4823 pushes (0.001 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• comm-central: 3

Platform breakdown:

• lint: 3

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1621235&startday=2020-04-06&endday=2020-04-12&tree=all

Comment 9

[Intermittent Failures Robot]

7 failures in 4528 pushes (0.002 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• comm-central: 7

Platform breakdown:

• lint: 7

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1621235&startday=2020-04-13&endday=2020-04-19&tree=all

Comment 10

[Intermittent Failures Robot]

4 failures in 5582 pushes (0.001 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• comm-central: 4

Platform breakdown:

• lint: 4

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1621235&startday=2020-04-20&endday=2020-04-26&tree=all

Comment 11

[Intermittent Failures Robot]

2 failures in 5423 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• comm-central: 2

Platform breakdown:

• lint: 2

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1621235&startday=2020-04-27&endday=2020-05-03&tree=all

Comment 12

[Intermittent Failures Robot]

5 failures in 5276 pushes (0.001 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• comm-central: 5

Platform breakdown:

• lint: 5

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1621235&startday=2020-05-04&endday=2020-05-10&tree=all

Comment 13

[Intermittent Failures Robot]

8 failures in 5488 pushes (0.001 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• comm-central: 8

Platform breakdown:

• lint: 8

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1621235&startday=2020-05-11&endday=2020-05-17&tree=all

Comment 14

[Intermittent Failures Robot]

2 failures in 4727 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• comm-central: 2

Platform breakdown:

• lint: 2

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1621235&startday=2020-05-18&endday=2020-05-24&tree=all

Comment 15

[Intermittent Failures Robot]

5 failures in 5458 pushes (0.001 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• comm-central: 5

Platform breakdown:

• lint: 5

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1621235&startday=2020-05-25&endday=2020-05-31&tree=all

Comment 16

[Intermittent Failures Robot]

3 failures in 4949 pushes (0.001 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• comm-central: 3

Platform breakdown:

• lint: 3

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1621235&startday=2020-06-01&endday=2020-06-07&tree=all

Comment 17

[Intermittent Failures Robot]

10 failures in 5211 pushes (0.002 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• comm-central: 10

Platform breakdown:

• lint: 10

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1621235&startday=2020-06-08&endday=2020-06-14&tree=all

Comment 18

[Intermittent Failures Robot]

7 failures in 4035 pushes (0.002 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• comm-central: 7

Platform breakdown:

• lint: 7

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1621235&startday=2020-06-15&endday=2020-06-21&tree=all

Comment 19

[Intermittent Failures Robot]

6 failures in 5252 pushes (0.001 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• comm-central: 6

Platform breakdown:

• lint: 6

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1621235&startday=2020-06-22&endday=2020-06-28&tree=all

Comment 20

[Intermittent Failures Robot]

9 failures in 4516 pushes (0.002 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• comm-central: 9

Platform breakdown:

• lint: 9

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1621235&startday=2020-06-29&endday=2020-07-05&tree=all

Comment 21

[Geoff Lankow (:darktrojan)]

Attachment: 1621235-eslint-imports-1.diff

This should stop the frequent failures. The imports are confusing ESLint when run in multiple processes, I think. I also stopped linting editor/** altogether since we don't ship that.

Comment 22

[Paul Morris [:pmorris]]

Comment on attachment 9161773 [details] [diff] [review]
1621235-eslint-imports-1.diff

Review of attachment 9161773 [details] [diff] [review]:
-----------------------------------------------------------------

These changes seem reasonable.  Tested by running mach eslint from the comm directory.  I got 34 errors, but then when I tried without the patch I got 33 errors, not exactly the same errors.  So there must be something wrong with my local setup.  (I'm usually linting the calendar dir and there were no errors in there.)  So r+, but it would be good to see a successful try run.

Comment 23

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/4bb55b313b29
Remove some ESLint import-globals-from loops to stop linting failures. r=pmorris

Comment 24

[Geoff Lankow (:darktrojan)]

it would be good to see a successful try run.

Here's one I prepared earlier:
https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=e964ae864d17e524376cc3cd2e419376dd52478d

Comment 25

[Intermittent Failures Robot]

2 failures in 5265 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• comm-central: 2

Platform breakdown:

• lint: 2

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1621235&startday=2020-07-06&endday=2020-07-12&tree=all

Comment 26

[Geoff Lankow (:darktrojan)]

Actually, yes let's fix this on ESR78. It's annoying noise we don't have to put up with.

Comment 27

[Geoff Lankow (:darktrojan)]

Comment on attachment 9161773 [details] [diff] [review]
1621235-eslint-imports-1.diff

This patch is all comments.

Comment 28

[Wayne Mery (:wsmwk)]

Comment on attachment 9161773 [details] [diff] [review]
1621235-eslint-imports-1.diff

[Triage Comment]
Approved for esr78

Comment 29

[Geoff Lankow (:darktrojan)]

Thunderbird 78.1.2:
https://hg.mozilla.org/releases/comm-esr78/rev/b026d727f510