1621449 - Unify Function data storage for FunctionBoxes

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P1)

Description

[Matthew Gaudet (he/him) [:mgaudet]]

Right now FunctionBoxes are in a peculiar state where the data about the function they represent is either stored 1) Directly on the FunctionBox, if it's a JSFunction, 2) In the CompilationInfo::funcData vector if it's a FunctionCreationData

By moving JSFunctions into the funcData array we get a couple of benefits:

1. FunctionBox gets simpler
2. We get a persistent identifier for a specific Function or Function-to-be, which will be useful in subsequent refactorings.

Comment 1

[Matthew Gaudet (he/him) [:mgaudet]]

Attachment: Bug 1621449 - Support storing JSFunctions inside of the funcData array r?tcampbell

Comment 2

[Matthew Gaudet (he/him) [:mgaudet]]

Attachment: Bug 1621449 - Use CompilationInfo::funcData to store FunctionBox JSFunctions r?tcampbell

Depends on D66317

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/175edca152be
Support storing JSFunctions inside of the funcData array r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/68a96136354c
Use CompilationInfo::funcData to store FunctionBox JSFunctions r=tcampbell

Comment 4

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/175edca152be
https://hg.mozilla.org/mozilla-central/rev/68a96136354c