1619345 - Disconnect ScriptStencil from js::FunctionBox

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P3)

Description

[Matthew Gaudet (he/him) [:mgaudet]]

Currently ScriptStencil stores the associated FunctionBox in order to call JSScript::initFromFunctionBox.

When we move stencils across threads, FunctionBox pointers will no longer be valid as they are LifoAlloc scoped and will die when the parser dies; so we'll need to disconnect ScriptStencil from directly refering to it.

At allocation time, we should be able to extract the relevant information from the functionbox.

Comment 1

[Matthew Gaudet (he/him) [:mgaudet]]

Attachment: Bug 1619345 - Create ImmutableScriptData before ScriptStencil, and transfer ownership to stencil r?tcampbell

Depends on D64455

Comment 2

[Matthew Gaudet (he/him) [:mgaudet]]

Attachment: Bug 1619345 - Rename BaseScript::immutableScriptFlags_ to immutableFlags_ to match mutableFlags_ r?tcampbell

Depends on D67568

Comment 3

[Matthew Gaudet (he/him) [:mgaudet]]

Attachment: Bug 1619345 - Refactor some flag setting code to support sharing in stencil initialization r?tcampbell

Depends on D67569

Comment 4

[Matthew Gaudet (he/him) [:mgaudet]]

Attachment: Bug 1619345 - Don't use ScriptStencil::functionBox for propagating flags r?tcampbell

Depends on D67570

Comment 5

[Matthew Gaudet (he/him) [:mgaudet]]

Attachment: Bug 1619345 - Remove FunctionBox reference in ScriptStencil r?tcampbell

Replace with a FunctionIndex

Depends on D67571

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d0bd6caf8d48
Create ImmutableScriptData before ScriptStencil, and transfer ownership to stencil r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/392aa4cee226
Rename BaseScript::immutableScriptFlags_ to immutableFlags_ to match mutableFlags_ r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/52a7e7b5c595
Don't use ScriptStencil::functionBox for propagating flags r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/187d340adf5e
Remove FunctionBox reference in ScriptStencil r=tcampbell

Comment 7

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/d0bd6caf8d48
https://hg.mozilla.org/mozilla-central/rev/392aa4cee226
https://hg.mozilla.org/mozilla-central/rev/52a7e7b5c595
https://hg.mozilla.org/mozilla-central/rev/187d340adf5e