1621452 - xpidllex.py / xpidlyacc.py are generated inconsistently

Status: RESOLVED FIXED

(Firefox Build System :: General, task, P3)

Description

[Michael Shal [:mshal]]

This is fallout from the python3 conversion. The output from header.py is inconsistently ordered in python3.5, and should be sorted. Note this doesn't appear to affect sccache stats, since I believe the source files that are generated from these python scripts still have a consistent output; it is only the python scripts themselves that are inconsistent.

Comment 1

[Michael Shal [:mshal]]

Actually, it looks like these files are written out by ply, so we'll need to update that library first and re-verify.

Comment 2

[Mike Hommey [:glandium]]

There is something confusing here. Ply doesn't actually support python3. If you run xpcom/idl-parser/xpidl/runtests.py with python3, it fails in ply. So I'm confused how the generated files work with python3... but they seem to. There is actually no currently released version of ply that supports python3, only a beta...

Anyways, it seems we haven't switched the other things that use ply (if I'm to believe the bug graph) to python 3, how about we "just" switch xpidl back to python 2 for now?

Comment 3

[Mike Hommey [:glandium]]

Attachment: Bug 1621452 - Generate xpidllex.py and xpidlyacc.py with python2.

Ply doesn't actually support python3. The generation of the files seems
to work with python3 for some reason, but running the corresponding
tests doesn't. The only version of ply that supports python3 is
currently in beta, so upgrading ply is probably not an option at the
moment.

Other commands that do use ply (mach webidl-parser-test and
ipc/ipdl/Makefile.in) have not switched to python3 (probably because
they don't work). Let's go with the simpler thing for now: switch back
to python 2 for xpidllex.py and xpidlyacc.py, which will make them
deterministically created again.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7a2a069c8641
Generate xpidllex.py and xpidlyacc.py with python2. r=rstewart

Comment 5

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/7a2a069c8641

Comment 7

[Intermittent Failures Robot]

1 failures in 4955 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• mozilla-central: 1

Platform breakdown:

• diff: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1621452&startday=2020-03-16&endday=2020-03-22&tree=all