1621359 - Update other-licenses/ply to support py3

Status: RESOLVED FIXED

(Firefox Build System :: General, task, P3)

Description

[Michael Shal [:mshal]]

Our version of ply doesn't work with python3, which blocks us from converting some uses of python2 during a build. According to the README, this comes from http://www.dabeaz.com/ply/

Comment 1

[Ricky Stewart]

Unfortunately the new Python 3-compatible version of PLY depends on Python 3.6.

Comment 2

[sagudev [:samson]]

According to https://github.com/dabeaz/ply/blob/master/CHANGES ply version 3.8 is still working with Python 3.5. Maybe even newer versions.

Comment 3

[Ricky Stewart]

I'm ambivalent about upgrading to an old version of ply (which, according to the changelog, is missing at least a couple bugfixes) just so we can maintain support for an old version of Python, but that could be an option in the short-term just to get us over the Py3 hump.

Comment 4

[Kris Wright :KrisWright]

Attachment: Bug 1621359 - Update .idl files to work with ply3

This pattern:

native nsSize (nsSize);
             ^

Causes a parsing error in ply 3.10. This can be easily fixed by removing the space and reformatting to this:

native nsSize(nsSize);

Comment 5

[Kris Wright :KrisWright]

Attachment: Bug 1621359 - Update ply to ply 3.10

This is the most recent version of ply to still support python 3.5.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fe6f888d24b8
Update .idl files to work with ply3 r=mccr8
https://hg.mozilla.org/integration/autoland/rev/71493b055359
Update ply to ply 3.10 r=firefox-build-system-reviewers,rstewart

Comment 7

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/fe6f888d24b8
https://hg.mozilla.org/mozilla-central/rev/71493b055359

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/6adb081c5677
Port bug 1621359 - Update .idl files to work with ply3. rs=bustage-fix