Closed Bug 1621475 Opened 5 years ago Closed 5 years ago

Use the new dump_syms tool in mingw builds

Categories

(Firefox Build System :: General: Unsupported Platforms, defect)

defect

Tracking

(firefox86 fixed)

RESOLVED FIXED
86 Branch
Tracking Status
firefox86 --- fixed

People

(Reporter: gsvelto, Assigned: gsvelto)

References

Details

Attachments

(1 file)

When we switched Windows builds to the oxidized dump_syms tool in bug 1594344 we failed to add the necessary bits to the mingw jobs too. As such the mingw builds lack symbols as seen in bug 1618819 for example.

I tried naively adding it to the tasks but it doesn't work: https://treeherder.mozilla.org/#/jobs?repo=try&revision=b94b02011556c2149bff39da26d4a986379c5424

I'll have a better look tomorrow.

I think I figured out how to fix this.

Assignee: nobody → gsvelto
Status: NEW → ASSIGNED

I managed to fix the downloading & finding dump_syms part of the problem but it's still not producing symbols, this needs more digging:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=076a9ec2d3ed7c285c223bff243e8bea60baf83d

mingw builds don't produce the same kind of symbols. I'm not even sure they enable the crashreporter.

It's not producing .pdb files? That would explain why it's not working then.

(In reply to Gabriele Svelto [:gsvelto] from comment #5)

It's not producing .pdb files? That would explain why it's not working then.

They produce .pdbs; but they are in a different place. Like the ASAN builds, they build next to the .exe/.dll

Because this bug's Severity has not been changed from the default since it was filed, and it's Priority is -- (Backlog,) indicating it has has not been previously triaged, the bug's Severity is being updated to -- (default, untriaged.)

Because this bug's Severity has not been changed from the default since it was filed, and it's Priority is -- (Backlog,) indicating it has has not been previously triaged, the bug's Severity is being updated to -- (default, untriaged.)

Because this bug's Severity has not been changed from the default since it was filed, and it's Priority is -- (Backlog,) indicating it has has not been previously triaged, the bug's Severity is being updated to -- (default, untriaged.)

Severity: normal → S3

The severity of these bugs was changed, mistakenly, from normal to S3.

Because these bugs have a priority of --, indicating that they have not been previously triaged, these bugs should be changed to Severity of --.

Severity: S3 → --
Blocks: 1654846
Blocks: 1580347

Tom, I noticed that when MOZ_COPY_PDBS is set - like in MinGW builds - we just skip the symbol-generation step:

https://searchfox.org/mozilla-central/rev/f8a41209af503016e78278774052d48d8c52b91c/config/rules.mk#661-663

Reading the comments in bug 1475562 this was a conscious choice because the old dump_syms wouldn't work. Now that we have a working dump_syms how do you suggest we proceed? Shall I try removing MOZ_COPY_PDBS and let MinGW builds use the normal flow as other builds?

Flags: needinfo?(tom)

(In reply to Gabriele Svelto [:gsvelto] from comment #11)

Reading the comments in bug 1475562 this was a conscious choice because the old dump_syms wouldn't work. Now that we have a working dump_syms how do you suggest we proceed? Shall I try removing MOZ_COPY_PDBS and let MinGW builds use the normal flow as other builds?

Absolutely. You may find that the pdbs are not in the expected place once generated and we need to special case MinGW somehow to either put them in the right place or look for them in a different place.

Flags: needinfo?(tom)

This uses the new cross-platform dump_syms tool to generate symbols for MinGW
builds, just like on all other platforms.

Pushed by gsvelto@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/2ff405d61101 Generate symbol files in MinGW builds r=tjr
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → 86 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: