1621632 - [Win7] Close button is not aligned with minimize and maximize in fullscreen mode

Status: RESOLVED FIXED

(Firefox :: Theme, defect)

Description

[Yaron]

User Agent: Mozilla/5.0 (Windows NT 6.1; rv:74.0) Gecko/20100101 Firefox/74.0

Steps to reproduce:

Press F11.
Hover over the top to show the Close/Minimize buttons.

Press the Full-Screen button on YouTube player.
Hover over the top to show ".pointerlockfswarning".

Actual results:

The Close button is 2px down and not aligned with the other buttons.
https://i.postimg.cc/gjzyKw78/1.png

The Full-Screen warning is cut off at the top
https://i.postimg.cc/6pfvM6dh/2.png.

Comment 1

[Timea Cernea [:tbabos][inactive]]

Hi Yaron,
I can also reproduce point 1 on all latest Firefox versions only on WIndows 7.
I can't reproduce the one with youtube, could you please mention which locale you are using?

Comment 2

[Yaron]

Hello Timea,

Thank you for confirming.
I'm using FF Hebrew.

Comment 3

[:Gijs (out for now; he/him)]

regression window is https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=d0d2e0f4b33cd28bc05c353c185873256f7f926e&tochange=7c96ad3ab6731287646616610e159447c69d6beb , so probably bug 1484422 broke the button thing.

Timea, can you confirm if you can repro the fullscreen warning issue with a Hebrew copy of Firefox, and if so, can you please file a separate bug for that (please CC the reporter and needinfo me), ideally also checking if that reproduces on Windows 8 or 10? If we could have a ballpark idea of when it regressed that would also be useful, as well as whether this happens only with youtube or with any in-page-triggered (ie DOM) fullscreen content.

Comment 4

[:Gijs (out for now; he/him)]

Attachment: Bug 1621632 - fix margins on close-button so it's positioned correctly on Windows 7, r?dao

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cb655661fbc8
fix margins on close-button so it's positioned correctly on Windows 7, r=dao

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

The component has been changed since the backlog priority was decided, so we're resetting it.
For more information, please visit auto_nag documentation.

Comment 7

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/cb655661fbc8

Comment 8

[Yaron]

Thank you all.

Comment 9

[Timea Cernea [:tbabos][inactive]]

Still can't reproduce the youtube one, checked latest Nightly with HE locale and Release 74 with the same locale...
Yaron, is that happening to all youtube videos? Could you share here one video where you see the issue?

Also, verified the fix in the latest Nightly (US and HE) (2020-03-22) on Windows 7 x64.

Comment 10

[:Gijs (out for now; he/him)]

(In reply to Timea Cernea [:tbabos] from comment #9)

Still can't reproduce the youtube one, checked latest Nightly with HE locale and Release 74 with the same locale...
Yaron, is that happening to all youtube videos? Could you share here one video where you see the issue?

Perhaps this only happens with some DPI or font settings? Yaron, any changes/customizations there, perhaps?

Comment 11

[Yaron]

NOTE: I'm not referring to the warning automatically displayed on moving to full-screen. This is displayed correctly.
When already in full-screen, hover over the top and wait for warning to appear. This time it's partially cut.
.pointerlockfswarning { margin-top: 15px !important; } fixes it.

No DPI or font changes.
It happens with a new profile and any local.

Comment 12

[Itiel]

(In reply to Yaron from comment #11)

NOTE: I'm not referring to the warning automatically displayed on moving to full-screen. This is displayed correctly.
When already in full-screen, hover over the top and wait for warning to appear. This time it's partially cut.
.pointerlockfswarning { margin-top: 15px !important; } fixes it.

No DPI or font changes.
It happens with a new profile and any local.

I think that's intentional, see:
https://searchfox.org/mozilla-central/rev/3fd53c47864fedb916f0ed8f002f15456324f729/browser/base/content/browser.css#899-902

Comment 13

[Yaron]

Well, if it's indeed intentional - I don't understand it. Showing half a dialog is weird IMO.
Anyway, this behavior started only in FF 72 or 73.