Closed
Bug 1484422
Opened 7 years ago
Closed 6 years ago
Clean up fullscreen window controls styling
Categories
(Firefox :: Theme, enhancement, P3)
Tracking
()
RESOLVED
FIXED
Firefox 63
| Tracking | Status | |
|---|---|---|
| firefox63 | --- | fixed |
People
(Reporter: dao, Assigned: dao)
References
Details
Attachments
(1 file)
|
1.49 KB,
patch
|
ntim
:
review+
|
Details | Diff | Splinter Review |
from bug 1483887 comment 4:
> > ::: browser/themes/linux/browser.css
> > @@ +153,5 @@
> > > +#minimize-button,
> > > +#restore-button,
> > > +#close-button {
> > > + -moz-appearance: none;
> > > + border: none;
> >
> > I'm not seeing any default border in toolbarbutton.css, is this needed ?
> >
> > @@ +154,5 @@
> > > +#restore-button,
> > > +#close-button {
> > > + -moz-appearance: none;
> > > + border: none;
> > > + margin: 0 !important;
> >
> > Is there a reason to use !important here ?
>
> I just copied this from the Windows stylesheet. Chances are we can simplify
> this in both places, so I'll file a followup on that.
|
Assignee | |
Updated•6 years ago
|
Assignee: nobody → dao+bmo
|
|
Assignee | |
Updated•6 years ago
|
Summary: Simplify fullscreen window controls styling → Clean up fullscreen window controls styling
|
|
Assignee | |
Comment 1•6 years ago
|
||
Attachment #9002706 -
Flags: review?(ntim.bugs)
|
||
Updated•6 years ago
|
Attachment #9002706 -
Flags: review?(ntim.bugs) → review+
|
|
Assignee | |
Updated•6 years ago
|
Keywords: checkin-needed
Pushed by ebalazs@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/95b2521e281c
Clean up fullscreen window controls styling. r=ntim
Keywords: checkin-needed
|
||
Comment 3•6 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 63
You need to log in
before you can comment on or make changes to this bug.
Description
•