Closed Bug 1621713 Opened 11 months ago Closed 7 months ago

Convert ActorPool to protocol.js Pool in devtools/server/connectors/js-window-actor/DevToolsFrameChild.jsm

Categories

(DevTools :: Framework, task, P3)

Product:
DevTools
Component:
Framework
Type:
task

Tracking

(firefox79 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 79
Tracking Flags:
Tracking Status
firefox79 --- fixed

People

(Reporter: jdescottes, Assigned: nchevobbe)

References

Details

Attachments

(1 file)

Bug 1621713 - Don't create extra ActorPools in devtools/server. r=jdescottes.
47 bytes, text/x-phabricator-request
Details | Review

ActorPool is a legacy class that should be replaced by protocol.js Pool.

https://searchfox.org/mozilla-central/rev/2fd8ffcf087bc59a8e5c962965bbb7bf230bcd28/devtools/server/connectors/js-window-actor/DevToolsFrameChild.jsm#76

Both classes have similar behavior, the cleanup should be mostly about renaming.

Assignee: nobody → nchevobbe
Status: NEW → ASSIGNED

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:nchevobbe, could you have a look please?
For more information, please visit auto_nag documentation.

Flags: needinfo?(nchevobbe)

the patch causes failures on TRY.

Flags: needinfo?(nchevobbe)
Attachment #9134455 - Attachment description: Bug 1621713 - Convert ActorPool to protocol.js Pool in devtools/server/connectors/js-window-actor/DevToolsFrameChild.jsm. r=jdescottes. → Bug 1621713 - Don't create extra ActorPools in devtools/server. r=jdescottes.
Pushed by nchevobbe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1c0f9cde882b
Don't create extra ActorPools in devtools/server. r=jdescottes.

https://hg.mozilla.org/mozilla-central/rev/1c0f9cde882b

Status: ASSIGNED → RESOLVED
Closed: 7 months ago
status-firefox79: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 79
You need to log in before you can comment on or make changes to this bug.