1621809 - Explicitly include members in js Cargo.toml, rather than exclude

Status: RESOLVED FIXED

(Core :: JavaScript Engine, enhancement, P3)

Description

[Adam Gashlin (he/him) [:agashlin] (ex-moco)]

Bug 1612515 added a list of directories to filter out from the workspace Cargo.toml when it makes a copy. So whenever a member is added to the workspace it must also be added to this exclude list (or to the list of copied directories). This bit me and caused a backout in bug 1515451 comment 6.

It seems like it would be less error-prone for this filter to state what directories to include, given that it is right next to the rsync input that lists the copied directories

Comment 1

[Ricky Stewart]

This looks more like a JS thing than a build system thing to me.

Comment 2

[Jason Orendorff [:jorendorff]]

arai, do you agree?

I think this is probably right, though I guess it will require slightly fancier shell hackery than grep to implement it.

Comment 3

[Tooru Fujisawa [:arai] (away until 08-17)]

I'll fix, but I guess it's not easy to do it with shell script. (it's possible, but I think it will become something not-readable)
I'll try rewriting it with python first.

Comment 4

[Tooru Fujisawa [:arai] (away until 08-17)]

Attachment: Bug 1621809 - Rewrite make-source-package.sh with python. r?sfink!

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/01276a1ff49c
Rewrite make-source-package.sh with python. r=sfink

Comment 6

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/01276a1ff49c