Closed Bug 1621809 Opened 5 months ago Closed 5 months ago

Explicitly include members in js Cargo.toml, rather than exclude

Categories

(Core :: JavaScript Engine, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla76
Tracking Status
firefox76 --- fixed

People

(Reporter: agashlin, Assigned: arai)

References

Details

(Keywords: in-triage)

Attachments

(1 file)

Bug 1612515 added a list of directories to filter out from the workspace Cargo.toml when it makes a copy. So whenever a member is added to the workspace it must also be added to this exclude list (or to the list of copied directories). This bit me and caused a backout in bug 1515451 comment 6.

It seems like it would be less error-prone for this filter to state what directories to include, given that it is right next to the rsync input that lists the copied directories

Keywords: in-triage
Component: General → JavaScript Engine
Product: Firefox Build System → Core

This looks more like a JS thing than a build system thing to me.

arai, do you agree?

I think this is probably right, though I guess it will require slightly fancier shell hackery than grep to implement it.

Flags: needinfo?(arai.unmht)
Priority: -- → P3

I'll fix, but I guess it's not easy to do it with shell script. (it's possible, but I think it will become something not-readable)
I'll try rewriting it with python first.

Assignee: nobody → arai.unmht
Status: NEW → ASSIGNED
Flags: needinfo?(arai.unmht)
Pushed by arai_a@mac.com:
https://hg.mozilla.org/integration/autoland/rev/01276a1ff49c
Rewrite make-source-package.sh with python. r=sfink
Status: ASSIGNED → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla76
You need to log in before you can comment on or make changes to this bug.