1621848 - messaging_example build fails with "error: cannot find symbol setMessageDelegate"

Status: RESOLVED FIXED

(GeckoView :: General, defect, P1)

Description

[Botond Ballo [:botond]]

STR

1. Build recent mozilla-central for Android
2. Run ./mach gradle installWithGeckoBinariesDebugAndroidTest

Actual results

The command fails with:

> Task :messaging_example:compileWithGeckoBinariesDebugJavaWithJavac FAILED
/home/botond/dev/mozilla/refactoring/mobile/android/examples/messaging_example/app/src/main/java/org/mozilla/geckoview/example/messaging/MainActivity.java:64: error: cannot find symbol
        session.setMessageDelegate(extension, messageDelegate, "browser");
               ^
  symbol:   method setMessageDelegate(WebExtension,MessageDelegate,String)
  location: variable session of type GeckoSession
1 error

Expected results

The command succeeds.

Comment 1

[Botond Ballo [:botond]]

Regression from bug 1616625?

Comment 2

[Botond Ballo [:botond]]

Side note:

2. Run ./mach gradle installWithGeckoBinariesDebugAndroidTest

I thought this command was supposed to install the "test runner" application that's needed to run mochitests and such. (The reason I use it is so that I can subsequently run ./mach mochitest with --no-install and not be prompted whether I want to install the test application.)

But it's actually (also) building a messaging_example application? Is it supposed to be doing that?

Comment 3

[Makoto Kato [:m_kato]]

./mach static-analysis check-java --outgoing is failure due to this.

Comment 4

[James Willcox (:snorp) ([e-mail]) (he/him)]

(In reply to Botond Ballo [:botond] from comment #2)

Side note:

2. Run ./mach gradle installWithGeckoBinariesDebugAndroidTest

I thought this command was supposed to install the "test runner" application that's needed to run mochitests and such. (The reason I use it is so that I can subsequently run ./mach mochitest with --no-install and not be prompted whether I want to install the test application.)

But it's actually (also) building a messaging_example application? Is it supposed to be doing that?

I think Gradle applies your command to all projects unless one is specified. Try ./mach gradle geckoview:installWithGeckoBinariesDebugAndroidTest

Comment 5

[Botond Ballo [:botond]]

(In reply to James Willcox (:snorp) ([e-mail]) (he/him) from comment #4)

I think Gradle applies your command to all projects unless one is specified. Try ./mach gradle geckoview:installWithGeckoBinariesDebugAndroidTest

Thanks, that explains why ./mach mochitest without --no-install was succeeding -- it knows to run the more specific command ./mach gradle geckoview:installWithGeckoBinariesDebugAndroidTest. (And now I know too!)

Comment 6

[[ex-Mozilla] Agi Sferro | :agi]

Thanks for the report, working on it.

Comment 7

[[ex-Mozilla] Agi Sferro | :agi]

Attachment: Bug 1621848 - Fix setMessageDelegate API change in example.

Comment 8

[[ex-Mozilla] Agi Sferro | :agi]

Attachment: Bug 1621848 - Build examples during |mach build|.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8e5f07a8b0b5
Fix setMessageDelegate API change in example. r=aklotz
https://hg.mozilla.org/integration/autoland/rev/ef28db75f142
Build examples during |mach build|. r=aklotz

Comment 10

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/8e5f07a8b0b5
https://hg.mozilla.org/mozilla-central/rev/ef28db75f142