Closed
Bug 1621873
Opened 4 years ago
Closed 4 years ago
Enforce mailTabs event/function permissions with the schema, not the code
Categories
(Thunderbird :: Add-Ons: Extensions API, task)
Thunderbird
Add-Ons: Extensions API
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 76.0
People
(Reporter: darktrojan, Assigned: darktrojan)
Details
Attachments
(1 file)
|
5.15 KB,
patch
|
mkmelin
:
review+
|
Details | Diff | Splinter Review |
When I first wrote the mailTabs API I didn't know that I could enforce permissions for an individual event using the schema, so I did it in the code instead. There's no real downside to this except that when the extension does not have permission it can still try to listen to the event, only for an exception to be thrown. Also documentation is easier when things are in the schema instead of the code.
|
Assignee | |
Updated•4 years ago
|
Summary: Enforce mailTabs event permissions with the schema, not the code → Enforce mailTabs event/function permissions with the schema, not the code
|
|
Assignee | |
Comment 1•4 years ago
|
||
Attachment #9132800 -
Flags: review?(mkmelin+mozilla)
|
||
Comment 2•4 years ago
|
||
Comment on attachment 9132800 [details] [diff] [review] 1621873-mailtabs-permissions-1.diff Review of attachment 9132800 [details] [diff] [review]: ----------------------------------------------------------------- Looks like an improvement! r=mkmelin
Attachment #9132800 -
Flags: review?(mkmelin+mozilla) → review+
|
|
Assignee | |
Updated•4 years ago
|
Keywords: checkin-needed-tb
Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/0ab55e9b87ee
Enforce mailTabs event/function permissions with the schema, not the code. r=mkmelin
|
|
||
Updated•4 years ago
|
Target Milestone: --- → Thunderbird 76.0
You need to log in
before you can comment on or make changes to this bug.
Description
•