Closed Bug 1622000 Opened 5 years ago Closed 5 years ago

Renaming of the contacts in the Chat not working

Categories

(Thunderbird :: Instant Messaging, defect)

Product:
Thunderbird
Component:
Instant Messaging
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(thunderbird68+ wontfix, thunderbird75 affected, thunderbird76 fixed)

Status:
RESOLVED FIXED
Milestone:
Thunderbird 76.0
Tracking Flags:
Tracking Status
thunderbird68 + wontfix
thunderbird75 --- affected
thunderbird76 --- fixed

People

(Reporter: khushil324, Assigned: khushil324)

Details

Attachments

(1 file)

Bug-1622000_renaming-contact-chat-not-working-0.patch
4.85 KB, patch
clokep
: review+
Details | Diff | Splinter Review

If you right-click on the contact and click on the "rename", nothing will happen.
Actual Result: You will see an input to edit the name of the contact.

Assignee: nobody → khushil324
Status: NEW → ASSIGNED
Attachment #9133174 - Flags: review?(clokep) → review+
Keywords: checkin-needed-tb

Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/22309738f263
fix renaming of the contacts in the Chat is not working. r=clokep

Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Keywords: checkin-needed-tb
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 76.0

Regression? Uplift?

As far as I can see, this is broken in TB 68. So who is managing the uplift here?

Flags: needinfo?(khushil324)
Flags: needinfo?(clokep)
status-thunderbird68: --- → affected
status-thunderbird75: --- → affected
status-thunderbird76: --- → fixed
tracking-thunderbird68: --- → +
Flags: needinfo?(khushil324)
Flags: needinfo?(clokep)
Comment on attachment 9133174 [details] [diff] [review] Bug-1622000_renaming-contact-chat-not-working-0.patch I think this should eventually go on 68.
Attachment #9133174 - Flags: approval-comm-esr68?
Comment on attachment 9133174 [details] [diff] [review] Bug-1622000_renaming-contact-chat-not-working-0.patch Approved for ESR
Attachment #9133174 - Flags: approval-comm-esr68? → approval-comm-esr68+

(In reply to Magnus Melin [:mkmelin] from comment #5)

Comment on attachment 9133174 [details] [diff] [review]
Bug-1622000_renaming-contact-chat-not-working-0.patch

I think this should eventually go on 68.

The file mail/components/im/content/chat-contact.js does not exist on c-esr68.

Flags: needinfo?(mkmelin+mozilla)
Comment on attachment 9133174 [details] [diff] [review] Bug-1622000_renaming-contact-chat-not-working-0.patch Review of attachment 9133174 [details] [diff] [review]: ----------------------------------------------------------------- Let's not do anything for 68 here after all. On 68 it's still XBL and all...
Attachment #9133174 - Flags: approval-comm-esr68+
status-thunderbird68: affected → wontfix
Flags: needinfo?(mkmelin+mozilla)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: