1622233 - Crash in [@ neqo_http3::transaction_client::{{impl}}::receive]

Status: RESOLVED FIXED

(Core :: Networking: HTTP, defect, P1)

Description

[Dragana Damjanovic [:dragana]]

This bug is for crash report bp-339a6bff-5a38-43d9-bf6f-b301c0200310.

Top 10 frames of crashing thread:

0 xul.dll RustMozCrash mozglue/static/rust/wrappers.cpp:16
1 xul.dll mozglue_static::panic_hook mozglue/static/rust/lib.rs:89
2 xul.dll core::ops::function::Fn::call<fn src/libcore/ops/function.rs:232
3 xul.dll std::panicking::rust_panic_with_hook src/libstd/panicking.rs:475
4 xul.dll std::panicking::begin_panic<str*> src/libstd/panicking.rs:404
5 xul.dll neqo_http3::transaction_client::{{impl}}::receive third_party/rust/neqo-http3/src/transaction_client.rs:269
6 xul.dll neqo_http3::connection::Http3Connection<neqo_http3::transaction_client::TransactionClient>::handle_read_stream<neqo_http3::transaction_client::TransactionClient> third_party/rust/neqo-http3/src/connection.rs:414
7 xul.dll neqo_http3::connection_client::Http3Client::check_connection_events third_party/rust/neqo-http3/src/connection_client.rs:338
8 xul.dll neqo_http3::connection_client::Http3Client::process_http3 third_party/rust/neqo-http3/src/connection_client.rs:277
9 xul.dll mozilla::net::Http3Session::ProcessInput netwerk/protocol/http/Http3Session.cpp:212

Comment 1

[Andy Grover [:grover]]

I think there's some inlining here, so this is actually in ResponseStream::receive().

Looking at that, there are two panic() statements for if ResponseStreamState is ClosePending or Closed. Could those be firing?

Comment 2

[Dragana Damjanovic [:dragana]]

Fixed by https://github.com/mozilla/neqo/pull/525 and uplift in bug 1628459