1622359 - Intermittent webrtc/RTCPeerConnection-generateCertificate.html.ini WPT FAIL with Fission

Status: RESOLVED DUPLICATE of bug 1402717

(Core :: WebRTC: Signaling, defect, P2)

Description

[Chris Peterson [:cpeterson]]

https://searchfox.org/mozilla-central/source/testing/web-platform/meta/webrtc/RTCPeerConnection-generateCertificate.html.ini

if (processor == "x86") and fission and debug: ["FAIL", "PASS"]
if (processor == "x86") and fission and not debug: ["PASS", "FAIL"]

Comment 1

[Dan Minor [:dminor]]

Hi Chris, is this something you're looking for the WebRTC team to fix? If so, what is your timeline? Thanks!

Comment 2

[Chris Peterson [:cpeterson]]

(In reply to Dan Minor [:dminor] from comment #1)

Hi Chris, is this something you're looking for the WebRTC team to fix?

Yes. The DOM Fission team is relying on feature teams to debug and fix Fission failures in their tests. If the failure looks like a bug in Fission's DOM or IPC changes, you can send the bug back to me.

If so, what is your timeline? Thanks!

We're hoping to enable Fission for a subset of Nightly users in early Q3, so we would like tests to be green for Fission by end of Q2. Whether a particular test failure actually blocks enabling Fission is up to the discretion of the feature team. You all would know better than the DOM Fission which WebRTC test failures are most important. :)

Comment 3

[Dan Minor [:dminor]]

Hi Jan-Ivar, as we discussed, could you please have a look to see if this is something we want to fix or disable for fission? Thanks!

Comment 4

[Chris Peterson [:cpeterson]]

btw, you can run WPT tests locally with Fission using mach wpt --enable-fission (from bug 1622338).

Comment 5

[Byron Campen [:bwc]]

Might be a dupe of 1607735? Does this actually happen anywhere other than windows?

Comment 6

[Chris Peterson [:cpeterson]]

(In reply to Byron Campen [:bwc] from comment #5)

Might be a dupe of 1607735? Does this actually happen anywhere other than windows?

This test is annotated as failing on all x86 platforms, regardless of OS. So I think we can close bug 1607735 as a dupe of this bug, since this bug is a superset.

if (processor == "x86") and fission and debug: ["FAIL", "PASS"]
if (processor == "x86") and fission and not debug: ["PASS", "FAIL"]

https://searchfox.org/mozilla-central/source/testing/web-platform/meta/webrtc/RTCPeerConnection-generateCertificate.html.ini

Comment 7

[Byron Campen [:bwc]]

(In reply to Chris Peterson [:cpeterson] from comment #6)

(In reply to Byron Campen [:bwc] from comment #5)

Might be a dupe of 1607735? Does this actually happen anywhere other than windows?

This test is annotated as failing on all x86 platforms, regardless of OS. So I think we can close bug 1607735 as a dupe of this bug, since this bug is a superset.

if (processor == "x86") and fission and debug: ["FAIL", "PASS"]
if (processor == "x86") and fission and not debug: ["PASS", "FAIL"]

https://searchfox.org/mozilla-central/source/testing/web-platform/meta/webrtc/RTCPeerConnection-generateCertificate.html.ini

wpt-sync bot did that automatically, and I don't necessarily trust its judgement.

Comment 8

[Byron Campen [:bwc]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=b29e9ee6cb5f97e3c0f1ca4307cc1b667d1308b3

Comment 10

[Byron Campen [:bwc]]

Check back on comment 8.

Comment 11

[Chris Peterson [:cpeterson]]

(In reply to Byron Campen [:bwc] from comment #7)

wpt-sync bot did that automatically, and I don't necessarily trust its judgement.

Oh. I was trying to be helpful and just closed Windows 7 bug 1607735 as a dupe of this bug, but feel free to re-open it that was premature.

Comment 12

[Byron Campen [:bwc]]

I'll just watch the try push, and update here as needed.

Comment 13

[Byron Campen [:bwc]]

Ok, looks like we need mach try fuzzy --full for the fission tests?

Comment 14

[Byron Campen [:bwc]]

FWIW, the test-windows10-64-qr/opt-web-platform-tests-fis-e10s job seems fine. Maybe it breaks if all of the webrtc wpt are run?

Comment 15

[Byron Campen [:bwc]]

Hopefully more fission tests in here: https://treeherder.mozilla.org/#/jobs?repo=try&revision=419f2e106b0740e36509049361942a1001461868

Comment 16

[Byron Campen [:bwc]]

test-windows10-64-qr/opt-web-platform-tests-fis-e10s for all of webrtc wpt: https://treeherder.mozilla.org/#/jobs?repo=try&revision=40bef52d43ed23b5f1f5af3cd20b593bbc8bc2d3

Comment 17

[Byron Campen [:bwc]]

I haven't seen any failures on these pushes. I will try one last push with the entire wpt suite, just in case.

Comment 18

[Byron Campen [:bwc]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=df9fcf68fc1c1f1bd2cf720aab2ccf9bbbd11078

Comment 19

[Byron Campen [:bwc]]

Yep, running the full suite leads to problems, at least on windows:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=df9fcf68fc1c1f1bd2cf720aab2ccf9bbbd11078&selectedTaskRun=QfP-aEnZS1e2AF507Jvijg-0

This is likely due to known flaws in our timer code on windows (see bug 1402717).

Comment 20

[Chris Peterson [:cpeterson]]

(In reply to Byron Campen [:bwc] from comment #19)

Yep, running the full suite leads to problems, at least on windows:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=df9fcf68fc1c1f1bd2cf720aab2ccf9bbbd11078&selectedTaskRun=QfP-aEnZS1e2AF507Jvijg-0

This is likely due to known flaws in our timer code on windows (see bug 1402717).

Byron, can we close this Fission bug as a dupe of timer bug 1402717? Or do you think there are other Fission-related problems here that need more investigation?

Comment 21

[Chris Peterson [:cpeterson]]

Tracking WPT Fission bugs for Fission M6b (Q2)

Comment 23

[Chris Peterson [:cpeterson]]

Clearing Fission Milestone for bugs resolved as duplicates. We don't need to track duplicates.