1622542 - Unable to see or copy saved password if Windows account's password is empty

Status: VERIFIED FIXED

(Firefox :: about:logins, defect, P1)

Description

[Gelirhil]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:76.0) Gecko/20100101 Firefox/76.0

Steps to reproduce:

There're two Windows 10 OS accounts in the system. One is a local non-privileged user with empty password and another is an admin user with MS online account login. When clicking on eye icon or "copy" button to see/copy saved password in about:logins a Windows security window with "Verify your identity to reveal the saved password" message pops up.

Actual results:

While under non-privileged system user:
Empty password for non-privileged system user is declined, security window pops up again.
E-mail and password identities for admin system user is also declined, security window pops up again.

While under admin system user:
Identities for admin system user is correctly accepted, saved password is shown.
Empty password for non-privileged system user is declined, security window pops up again.

Expected results:

Security window must accept empty user password or shouldn't pop up at all if system user password is empty.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Bugbug thinks this bug should belong to this component, but please revert this change in case of error.

Comment 3

[Matthew N. [:MattN]]

Thanks for the report!

[Tracking Requested - why for this release]: New feature won't work for users without a Windows account password

Comment 4

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1622542 - Skip showing the credential UI for user accounts with a blank password. r?keeler!,agashlin!

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b50418331e04
Skip showing the credential UI for user accounts with a blank password. r=keeler

Comment 7

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/b50418331e04

Comment 8

[Cosmin Muntean [:cmuntean], Ecosystem QA]

I have verified this issue and is no longer reproducible on Windows, the OS auth is no longer triggered if the no OS password is set. I have tested this issue using the latest Nightly 76.0a1 build (Build ID: 20200319215651) on Windows 10 x64, Windows 8.1 x64, Windows 7 x32, macOS 10.15.3 and macOS 10.14.6.

• Unfortunately, this issue is still reproducible on macOS. I have logged this issue for macOS in bug 1623861.