Closed Bug 1622607 Opened 5 years ago Closed 5 years ago

Protocol options in the chat account wizard are not getting saved in the account manager

Categories

(Thunderbird :: Instant Messaging, defect)

Product:
Thunderbird
Component:
Instant Messaging
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(thunderbird75 fixed)

Status:
RESOLVED FIXED
Milestone:
Thunderbird 76.0
Tracking Flags:
Tracking Status
thunderbird75 --- fixed

People

(Reporter: khushil324, Assigned: khushil324)

Details

Attachments

(2 files)

Bug-1622607_protocol-options-chat-not-saved-0.patch
1.62 KB, patch
clokep
: review+
wsmwk
: approval-comm-beta+
Details | Diff | Splinter Review
Bug-1622607_follow-up-protocol-options-chat-not-saved-0.patch
2.54 KB, patch
clokep
: review+
wsmwk
: approval-comm-beta+
Details | Diff | Splinter Review
No description provided.
Assignee: nobody → khushil324
Status: NEW → ASSIGNED

This sounds an awful lot like bug 1562314.

Is there a way to add a test here so this stops regressing?

Comment on attachment 9133425 [details] [diff] [review] Bug-1622607_protocol-options-chat-not-saved-0.patch Review of attachment 9133425 [details] [diff] [review]: ----------------------------------------------------------------- Any idea if this needs to get backported?
Attachment #9133425 - Flags: review?(clokep) → review+
Keywords: checkin-needed-tb

(In reply to Patrick Cloke [:clokep] from comment #3)

Any idea if this needs to get backported?

Yes, we need it for beta. Not sure about the ESR 68.

Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/d5fd015190ad
fix protocol options in the chat account wizard are not getting saved in the account manager. r=clokep DONTBUILD

Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Keywords: checkin-needed-tb
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 76.0

(In reply to Khushil Mistry [:khushil324] from comment #4)

(In reply to Patrick Cloke [:clokep] from comment #3)

Any idea if this needs to get backported?

Yes, we need it for beta. Not sure about the ESR 68.

Great. Could you check and make sure this is working on ESR? Thank you!

Attachment #9133425 - Flags: approval-comm-beta?

(In reply to Patrick Cloke [:clokep] from comment #6)

Great. Could you check and make sure this is working on ESR? Thank you!

Don't see this problem in ESR 68.

Some changes were left in the last patch.

Attachment #9135158 - Flags: review?(clokep)
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Comment on attachment 9135158 [details] [diff] [review] Bug-1622607_follow-up-protocol-options-chat-not-saved-0.patch Seems reasonable. Is there a way we can refactor this to not have similar code scattered everywhere? Might be worth filing a separate follow-up about that.
Attachment #9135158 - Flags: review?(clokep) → review+
Attachment #9133425 - Flags: approval-comm-beta? → approval-comm-beta+
Keywords: checkin-needed-tb

Pushed by thunderbird@calypsoblue.org:
https://hg.mozilla.org/comm-central/rev/6638944e18ba
Follow-up: Protocol options in the chat account wizard are not getting saved in the account manager. r=clokep

Status: REOPENED → RESOLVED
Closed: 5 years ago → 5 years ago
Keywords: checkin-needed-tb
Resolution: --- → FIXED
Comment on attachment 9135158 [details] [diff] [review] Bug-1622607_follow-up-protocol-options-chat-not-saved-0.patch This should go on beta with the first half of the fix.
Attachment #9135158 - Flags: approval-comm-beta?
Comment on attachment 9135158 [details] [diff] [review] Bug-1622607_follow-up-protocol-options-chat-not-saved-0.patch [Triage Comment]
Attachment #9135158 - Flags: approval-comm-beta? → approval-comm-beta+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: