1622617 - Cannot see raw data of websocket frames

Status: VERIFIED FIXED

(DevTools :: Netmonitor, defect, P1)

Description

[Pranav pandey]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:73.0) Gecko/20100101 Firefox/73.0

Comment 1

[Pranav pandey]

Its very strange , I could see the element in the browser toolbox, https://www.youtube.com/watch?v=NO7jFcoID8s

Comment 2

[Augusto Pace]

Hi,

I was able to reproduce this issue on Windows 10 with Firefox version Nightly 76.0a1 (2020-03-18) (64-bit) - Beta 75.0b5 (64-bit) - Release 74.0 (64-bit). Marking those flags as affected.

Also I'm setting component to Devtools - Netmonitor and status to NEW for someone to take a look at this.

Comment 3

[:Harald Kirschner :digitarald]

Bomsy, could this be accordion related? It doesn't seem to be a regression.

The content appears with the following change, which is strange as the textarea inside .accordion-content has a height.

/* Accordion.css | resource://devtools/client/shared/components/Accordion.css */

.accordion-content {
  /* overflow: auto; */
}

Comment 4

[Hubert Boma Manilla (:bomsy)]

Yeah it is accordion related. It is probably a regression from the response panel work.

Here is the css that causes the issue
https://searchfox.org/mozilla-central/rev/6cd54550a27e2f6ca0755a25328f769e41e524f4/devtools/client/netmonitor/src/assets/styles/NetworkDetailsBar.css#75

Comment 5

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Thanks Hubert for the analysis!

Mark as P1, this should be fixed asap and feels like we know what to do.

Honza

Comment 6

[Hubert Boma Manilla (:bomsy)]

Attachment: Bug 1622617 - Fixed showing the websocket frames r=honza

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b3eb47d62fa0
Fixed showing the websocket frames r=Honza

Comment 8

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/b3eb47d62fa0

Comment 9

[:Harald Kirschner :digitarald]

[Tracking Requested - why for this release]: Small fix that avoid loosing data in the UI.

Comment 10

[Julien Cristau [:jcristau]]

Please request beta uplift when you get a chance.

Comment 11

[Hubert Boma Manilla (:bomsy)]

Comment on attachment 9134664 [details]
Bug 1622617 - Fixed showing the websocket frames r=honza

Beta/Release Uplift Approval Request

• User impact if declined: Impacts only developers, websocket frames not showing
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Only affects developers, small patch, only css changes
• String changes made/needed:

Comment 12

[Julien Cristau [:jcristau]]

I should maybe have caught this earlier, but... this bug is set as "regressed by 1613885". Bug 1613885 is only in 76. How is 75 even affected here?

Comment 13

[Hubert Boma Manilla (:bomsy)]

Oh yeah .. that is correct! missed that.
harald do you agree?

Comment 14

[:Harald Kirschner :digitarald]

I saw this on 75 as well, and so states comment 5 as well, so I am not sure if this is a regression. Would the uplift improve this for 75?

Comment 15

[Julien Cristau [:jcristau]]

Based on comments 2/3/14 I'll clear the regression info here.

Comment 16

[Julien Cristau [:jcristau]]

Comment on attachment 9134664 [details]
Bug 1622617 - Fixed showing the websocket frames r=honza

approved for 75.0b10, but asking for verification.

Comment 17

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/releases/mozilla-beta/rev/d000a811d5ed

Comment 18

[Augusto Pace]

Hi,

I was able to reproduce this issue on Firefox version 74. And then I was able to verify the fix on Windows 10, Mac OS 10.14 and Ubuntu 18, with Firefox version Nigthly 76.0a1 - Build ID 20200327094805 and Beta 75.0b10 Build ID 20200326191140. Making those flags as verified.

Also I'm setting status to VERIFIED and removing [qa-triaged] and qe-verify+ flags.

Thanks.