1613885 - Use Accordion for the Response Panel

Status: RESOLVED FIXED

(DevTools :: Netmonitor, defect, P3)

Description

[Jan Honza Odvarko [:Honza] (always need-info? me)]

The Response panel should used Accordion component [1] to render its sections
The panel should also be moved into a new request-details directory.

Sections:

• Payload
• HTML/JSON preview

[1] https://searchfox.org/mozilla-central/rev/3811b11b5773c1dccfe8228bfc7143b10a9a2a99/devtools/client/shared/components/Accordion.js#20

Honza

Comment 1

[Hubert Boma Manilla (:bomsy)]

Attachment: Bug 1613885 - Refactor Response panel and use accordion r=honza

Bug 1613885 - Move response panel file to request-details/ r=honza
Bug 1613885 - refacator response panel, move HtmlPreview, add ImagePreview r=honza
Bug 1613885 - fix lint issues r=honza
Bug 1613885 - cleanup code which is no longer needed r=honza
Bug 1613885 - fix lint issues r=honza

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8c7e3a9b7b6b
Refactor Response panel and use accordion r=Honza

Comment 3

[Oana Pop-Rus]

Backed out changeset 8c7e3a9b7b6b (bug 1613885) for dt failures in browser_net_content-type.js

Push that started the failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=pending%2Crunning%2Csuccess%2Csuperseded%2Ctestfailed%2Cbusted%2Cexception%2Crunnable&searchStr=devtools&tochange=8c7e3a9b7b6bc584c29432eb4d5f3c35b7877026&fromchange=6a03a1ccc1facad394408a7cdcef68f979f8cd4b&selectedJob=292823903

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=292823903&repo=autoland&lineNumber=3553

Backout: https://hg.mozilla.org/integration/autoland/rev/060b5c64b13d271ff553b7099f9b1c6431f748bf

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/385720d88f1e
Refactor Response panel and use accordion r=Honza

Comment 5

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/385720d88f1e