Closed Bug 1622657 Opened 4 months ago Closed 1 month ago

the 'empty' method should be used to check for emptiness instead of 'size'

Categories

(Firefox Build System :: Source Code Analysis, task)

task
Not set
minor

Tracking

(firefox78 fixed)

RESOLVED FIXED
mozilla78
Tracking Status
firefox78 --- fixed

People

(Reporter: Sylvestre, Assigned: nikolaoutheod, Mentored)

References

(Blocks 1 open bug)

Details

(Keywords: good-first-bug, Whiteboard: [lang=C++])

Attachments

(1 file)

+++ This bug was initially created as a clone of Bug #1622653 +++

Filling as a good first bug to learn workflows.

if (values_.size() == 0) {
should use .empty() instead

https://searchfox.org/mozilla-central/source/js/src/frontend/BinASTTokenReaderContext.cpp#2169
and
https://searchfox.org/mozilla-central/source/js/src/frontend/BinASTTokenReaderContext.cpp#2227

As the change is trivial, it is just to learn how to contribute to Firefox.

Found by http://clang.llvm.org/extra/clang-tidy/checks/readability-container-size-empty.html

Tutorial to contribute:
https://firefox-source-docs.mozilla.org/tools/docs/contribute/how_to_contribute_firefox.html

Please don't ask for the bug to be assigned. It will be automatically assigned to the first patch.

Mentor: sledru
Keywords: good-first-bug
Whiteboard: [lang=C++]

Hello,
I want to work on thins task, can i get assigned to it please ?

Flags: needinfo?(sledru)

Please read the last line of the description of the bug ;)

Flags: needinfo?(sledru)

I made the requested change but i got stuck to the pull request upload process.
I generated the ssh key as mentioned in https://wiki.mozilla.org/Sheriffing/How_To/Getting_started_as_a_sheriff
but unfotunately i could not upload the public one in https://login.mozilla.com/ssh_keys_index.
Which username and password is needed? How could i reset them to be able to connect in this page and upload my public ssh key?

Flags: needinfo?(sledru)

I am sorry but I don't know what you are talking about exactly
You cannot push a change to phabricator. Is that correct?

Flags: needinfo?(sledru)

Yes because i cannot upload my public key to https://login.mozilla.com/ssh_keys_index to later establish a SSH connection.
Is there an alternative?

where did you see that you need an ssh key ?
afaik, this isn't needed.
See the doc here
https://moz-conduit.readthedocs.io/en/latest/phabricator-user.html

Assignee: nobody → nikolaoutheod
Status: NEW → ASSIGNED
Status: ASSIGNED → RESOLVED
Closed: 1 month ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla78
You need to log in before you can comment on or make changes to this bug.