1622659 - HTMLInputElement.cpp: do not use 'else' after 'return'

Status: RESOLVED FIXED

(Developer Infrastructure :: Source Code Analysis, task)

Description

[Sylvestre Ledru [:Sylvestre]]

+++ This bug was initially created as a clone of Bug #1622653 +++

Filling as a good first bug to learn workflows.

      return;
    } else {
      ClearFiles(true);
    }

do not use 'else' after 'return'

https://searchfox.org/mozilla-central/source/dom/html/HTMLInputElement.cpp#1568

As the change is trivial, it is just to learn how to contribute to Firefox.

Found by http://clang.llvm.org/extra/clang-tidy/checks/readability-else-after-return.html

Tutorial to contribute:
https://firefox-source-docs.mozilla.org/tools/docs/contribute/how_to_contribute_firefox.html

Please don't ask for the bug to be assigned. It will be automatically assigned to the first patch.

Comment 1

[anir1ghosh]

Attachment: Bug 1622659 - Do not use 'else' after 'return' in HTMLInputElement

Comment 2

[Eames]

Attachment: Bug 1622659 - Removed 'else' after 'return' in HTMLInputElement - r?emilio

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5dec62686a5f
Removed 'else' after 'return' in HTMLInputElement - r=emilio

Comment 4

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/5dec62686a5f