1622665 - ActorsParent.cpp: redundant access specifier has the same accessibility as the previous access specifier

Status: RESOLVED FIXED

(Developer Infrastructure :: Source Code Analysis, task)

Description

[Sylvestre Ledru [:Sylvestre]]

+++ This bug was initially created as a clone of Bug #1622663 +++

Filling as a good first bug to learn workflows.

protected:
  const bool mClear;

 protected:
  ClearRequestBase(bool aExclusive, bool aClear)
      : QuotaRequestBase(aExclusive), mClear(aClear) {

redundant access specifier has the same accessibility as the previous access specifier
here, protected is declared twice

https://searchfox.org/mozilla-central/source/dom/quota/ActorsParent.cpp#1589-1593

As the change is trivial, it is just to learn how to contribute to Firefox.

http://clang.llvm.org/extra/clang-tidy/checks/readability-redundant-access-specifiers.html

Tutorial to contribute:
https://firefox-source-docs.mozilla.org/tools/docs/contribute/how_to_contribute_firefox.html

Please don't ask for the bug to be assigned. It will be automatically assigned to the first patch.

Comment 1

[nd419]

This change appears to be done, no fix necessary?

Comment 2

[Sylvestre Ledru [:Sylvestre]]

Indeed, please let me know if you want another bug!
Thanks

Comment 3

[nd419]

Yes please, was looking for a first bug to get into contributing, however, was having issues with OAuth in phabricator, any ideas on how to resolve this?

Thanks

Comment 4

[Sylvestre Ledru [:Sylvestre]]

Dunno and bugzilla isn't the best place for this ;)
Maybe bug 1622662 ?
or bug 1622660
bug 1629419