Closed
Bug 1622683
Opened 5 years ago
Closed 4 years ago
dom/websocket: Make it flake8 compliant
Categories
(Developer Infrastructure :: Lint and Formatting, task)
Developer Infrastructure
Lint and Formatting
Tracking
(firefox82 fixed)
RESOLVED
FIXED
82 Branch
| Tracking | Status | |
|---|---|---|
| firefox82 | --- | fixed |
People
(Reporter: Sylvestre, Assigned: mail, Mentored)
References
Details
(Keywords: good-first-bug, Whiteboard: [lang=python])
Attachments
(1 file)
+++ This bug was initially created as a clone of Bug #1622682 +++
Filling as a good first bug to learn workflows.
As the change is easy, it is mostly to learn how to contribute to Firefox.
To work on this, remove this line:
https://searchfox.org/mozilla-central/source/.flake8#13
To run the linter:
$ ./mach lint -l flake8 dom/websocket
To run the autofix:
$ ./mach lint -l flake8 --fix dom/websocket/
Then, the remaining thing should be fixed by hand.
Tutorial to contribute:
https://firefox-source-docs.mozilla.org/tools/docs/contribute/how_to_contribute_firefox.html
Please don't ask for the bug to be assigned. It will be automatically assigned to the first patch.
|
Assignee | |
Comment 1•4 years ago
|
||
|
||
Updated•4 years ago
|
Assignee: nobody → pfischbeck
Status: NEW → ASSIGNED
|
|
||
Updated•4 years ago
|
Attachment #9173039 -
Attachment description: Bug 1622683 - Make dom/websocket flake8 compliant. r?sylvestre → Bug 1622683 - Make dom/websocket flake8 and pylint compliant. r?sylvestre
Pushed by sledru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/dfd3eb3545d5
Make dom/websocket flake8 and pylint compliant. r=sylvestre
|
||
Comment 3•4 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox82:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 82 Branch
|
||
Updated•3 years ago
|
Product: Firefox Build System → Developer Infrastructure
You need to log in
before you can comment on or make changes to this bug.
Description
•