1622783 - Cursor should update position when console input is resized and caused lines to wrap

Status: RESOLVED DUPLICATE of bug 1624531

(DevTools :: Console, defect, P3)

Description

[Cristian Fogel [:cfogel]]

Attachment: cursorPostition.gif

Affected versions

• 75.0b4; 73.0b6, 76.0a1 (2020-03-15)

Affected platforms

• Windows 10, macOS 10.15, Ubuntu 18.04;

Steps to reproduce

1. Launch Firefox, enable DevTools, select the Console tab;
2. Type in the following expression:
   ` Spans with 'e': `+ Array.from(document.querySelectorAll("span")) .map(el => el.textContent) .filter(s => s.includes("e")) .join(" ")
3. Ensure the mouse cursor is at the end of the string(can also click);
4. Press CTRL+Shift+B(enable Multi-Line) mode;
5. Repeat step 4;

Expected result

• cursor is at the last character in the input;

Actual result

• step 4: cursor is in the middle of the expression;
• step 5: cursor is 1 row bellow even tho there were no extra space_characters pasted;

Regression range

• will check if a regression and provide one asap;

Additional notes

• attached recording with the issue.

Comment 1

[Daniel Cicas [:dcicas], Release QA]

Regression range:
Last good: 2019-06-28
First bad: 2019-06-29
Pushlog: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=af62dfeb5c0eeb6e5bf5a8626f2556f3fa0d7cd2&tochange=938ba43a3350c4f81a5ed152b02eb92f9e68c949

Comment 2

[Nicolas Chevobbe [:nchevobbe]]

The issue here is that the cursor position should be updated if the expression is wrapped.
We should call refresh() on codeMirror when resizing the editor or switching between inline and editor mode.

Comment 3

[u654212]

Hi,
I want to work on this bug could you please assign it to me?

Comment 4

[Nicolas Chevobbe [:nchevobbe]]

sure, it's yours now :)

Comment 5

[Firefox Bug Husbandry Bot]

Because this bug's Severity has not been changed from the default since it was filed, and it's Priority is P3 (Backlog,) indicating it has been triaged, the bug's Severity is being updated to S3 (normal.)

Comment 6

[Nicolas Chevobbe [:nchevobbe]]

This was fixed by Bug 1624531

Comment 7

[Cristian Fogel [:cfogel]]

Quick check with 80.0a1 (2020-07-26), confirmed.