Assert network is always present in GVE and TestRunnerActivity
Categories
(GeckoView :: GeckoViewExample, task, P1)
Tracking
(firefox76 fixed)
Tracking | Status | |
---|---|---|
firefox76 | --- | fixed |
People
(Reporter: snorp, Assigned: snorp)
References
Details
(Whiteboard: [geckoview:m76])
Attachments
(1 file)
Sometimes in automation (particularly when running on physical devices), the device will lose connectivity and we will get mysterious failures. We should monitor the network status in GVE and TestRunnerActivity and crash immediately if the network is lost.
Assignee | ||
Comment 1•4 years ago
|
||
When running mochitests on real hardware, we sometimes lose the network,
causing strange timeouts. It's better if we crash immediately in those
situations to avoid confusion.
Updated•4 years ago
|
Assignee | ||
Updated•4 years ago
|
Pushed by jwillcox@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/502775f3a9cf Ensure network is always available in TestRunnerActivity r=geckoview-reviewers,agi
Comment 3•4 years ago
|
||
Backed out changeset 502775f3a9cf (bug 1622816) for android Bpgo(run) exceptions
Backout: https://hg.mozilla.org/integration/autoland/rev/4705d6d0630587758fbe9067d34d1a785271c303
Comment 4•4 years ago
|
||
03-19 14:10:13.925 887 887 W dalvikvm: Unable to resolve superclass of Lorg/mozilla/geckoview/test/TestRunnerActivity$5; (415)
03-19 14:10:13.925 887 887 W dalvikvm: Link of class 'Lorg/mozilla/geckoview/test/TestRunnerActivity$5;' failed
03-19 14:10:13.925 887 887 E dalvikvm: Could not find class 'org.mozilla.geckoview.test.TestRunnerActivity$5', referenced from method org.mozilla.geckoview.test.TestRunnerActivity.ensureNetworkAvailable
03-19 14:10:13.925 887 887 W dalvikvm: VFY: unable to resolve new-instance 8082 (Lorg/mozilla/geckoview/test/TestRunnerActivity$5;) in Lorg/mozilla/geckoview/test/TestRunnerActivity;
03-19 14:10:13.925 887 887 D dalvikvm: VFY: replacing opcode 0x22 at 0x0008
03-19 14:10:13.954 887 887 W dalvikvm: Unable to resolve superclass of Lorg/mozilla/geckoview/test/TestRunnerActivity$5; (415)
03-19 14:10:13.954 887 887 W dalvikvm: Link of class 'Lorg/mozilla/geckoview/test/TestRunnerActivity$5;' failed
03-19 14:10:13.965 887 887 D dalvikvm: DexOpt: unable to opt direct call 0xcceb at 0x0a in Lorg/mozilla/geckoview/test/TestRunnerActivity;.ensureNetworkAvailable
03-19 14:10:13.985 887 887 D AndroidRuntime: Shutting down VM
03-19 14:10:13.995 887 887 W dalvikvm: threadid=1: thread exiting with uncaught exception (group=0x414c8700)
03-19 14:10:14.004 887 887 E AndroidRuntime: FATAL EXCEPTION: main
03-19 14:10:14.004 887 887 E AndroidRuntime: java.lang.NoClassDefFoundError: org.mozilla.geckoview.test.TestRunnerActivity$5
03-19 14:10:14.004 887 887 E AndroidRuntime: at org.mozilla.geckoview.test.TestRunnerActivity.ensureNetworkAvailable(TestRunnerActivity.java:266)
03-19 14:10:14.004 887 887 E AndroidRuntime: at org.mozilla.geckoview.test.TestRunnerActivity.onCreate(TestRunnerActivity.java:285)
03-19 14:10:14.004 887 887 E AndroidRuntime: at android.app.Activity.performCreate(Activity.java:5133)
03-19 14:10:14.004 887 887 E AndroidRuntime: at android.app.Instrumentation.callActivityOnCreate(Instrumentation.java:1087)
03-19 14:10:14.004 887 887 E AndroidRuntime: at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:2175)
03-19 14:10:14.004 887 887 E AndroidRuntime: at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:2261)
03-19 14:10:14.004 887 887 E AndroidRuntime: at android.app.ActivityThread.access$600(ActivityThread.java:141)
03-19 14:10:14.004 887 887 E AndroidRuntime: at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1256)
03-19 14:10:14.004 887 887 E AndroidRuntime: at android.os.Handler.dispatchMessage(Handler.java:99)
03-19 14:10:14.004 887 887 E AndroidRuntime: at android.os.Looper.loop(Looper.java:137)
03-19 14:10:14.004 887 887 E AndroidRuntime: at android.app.ActivityThread.main(ActivityThread.java:5103)
03-19 14:10:14.004 887 887 E AndroidRuntime: at java.lang.reflect.Method.invokeNative(Native Method)
03-19 14:10:14.004 887 887 E AndroidRuntime: at java.lang.reflect.Method.invoke(Method.java:525)
03-19 14:10:14.004 887 887 E AndroidRuntime: at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:737)
03-19 14:10:14.004 887 887 E AndroidRuntime: at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:553)
03-19 14:10:14.004 887 887 E AndroidRuntime: at dalvik.system.NativeStart.main(Native Method)
03-19 14:10:14.015 275 275 W ActivityManager: Force finishing activity org.mozilla.geckoview.test/.TestRunnerActivity
I think the pgo stuff is still running on Android 4.3.
Pushed by jwillcox@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/e08a5c2df047 Ensure network is always available in TestRunnerActivity r=geckoview-reviewers,agi
Comment 6•4 years ago
|
||
bugherder |
Comment 7•4 years ago
|
||
This appears to only affect the TestRunnerActivity and has no effect on tests which only use geckoview_example. For example running raptor with
./mach raptor-test --test=raptor-tp6m-6-cold --app=geckoview --binary=org.mozilla.geckoview_example --activity=org.mozilla.geckoview_example.GeckoViewActivity
Does not detect a disabled network. I am beginning to think that this partial solution is worse than no solution at all.
Description
•