1624715 - Remove network assertion introduced in Bug 1622816

Status: RESOLVED FIXED

(GeckoView :: General, enhancement)

Description

[Bob Clary [:bc] (inactive)]

Bug 1622816 introduced a run time exception in TestRunnerActivity when the network is either not present or is lost. This only works with TestRunnerActivity and not for Raptor which uses geckoview_example. The edge cases and the other side-effects such as the need to generate crash reports for run time exceptions or to handle the run time exceptions in Treeherder parsing mean my original idea to detect networking issues at bitbar was not well thought out.

We should just revert the patch in Bug 1622816, wontfix Bug 1624210 and its dependencies. If we want to revisit this, we should have a better understanding of the interactions with the test frameworks.

Comment 1

[Bob Clary [:bc] (inactive)]

Attachment: Bug 1624715 - Remove network assertion introduced in Bug 1622816, r=snorp.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dd82e0be7f03
Remove network assertion introduced in Bug 1622816, r=snorp.

Comment 3

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/dd82e0be7f03