1622845 - Turn on HTTP/3 tests on TSan builds

Status: RESOLVED FIXED

(Core :: Networking: HTTP, task, P2)

Description

[Michal Novotny [:michal]]

TSan build of http3server throws a panic during NSS initialization due to unresolved symbols in libmozsqlite3.so:

dlopen failed with: /builds/worker/workspace/build/application/firefox/libmozsqlite3.so: undefined symbol: __tsan_unaligned_read2

Comment 1

[Nathan Froyd [:froydnj]]

(In reply to Michal Novotny [:michal] from comment #0)

TSan build of http3server throws a panic during NSS initialization due to unresolved symbols in libmozsqlite3.so:

dlopen failed with: /builds/worker/workspace/build/application/firefox/libmozsqlite3.so: undefined symbol: __tsan_unaligned_read2

Where is libtsan getting linked in the Firefox build? Is it statically linked in something like mozglue (doesn't look like it) or is it dynamically linked and therefore dynamically loading libmozsqlite3.so needs to be aware of where the tsan dynamic library is also?

Comment 2

[Christian Holler (:decoder)]

TSan is statically linked by passing -fsanitize=thread during linking. Clang links the runtime automatically.

In order to solve your build problem, you need to ensure that you compile and link with -fsanitize=thread.

Comment 3

[Kershaw Chang [:kershaw]]

Attachment: Bug 1622845 - Enable http3 tsan tests, r=#necko

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/29fbedff9ab6
Enable http3 tsan tests, r=necko-reviewers,valentin

Comment 5

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/29fbedff9ab6