1622860 - Titlebar of Address Book and composer light when dark theme is chosen

Status: RESOLVED FIXED

(Thunderbird :: Theme, enhancement)

Description

[Richard Marti (:Paenglab)]

The Address Book and the composer window have with the default TB theme a unified title-/toolbar. When a theme is chosen the toolbars are correctly painted but the titlebar is now light and no more unified with the toolbar. With the dark system theme it's worse because the light titlebars stand out more.

Comment 1

[Richard Marti (:Paenglab)]

Attachment: 1622860-Mac-AB-composer-titlebar.patch

This is a little bit hacky because the titlebar is inside the toolbox but this fixes the issue and shows always a unified title-/toolbar. Actually the titlebar construct is no more used, with this patch it's used again.

Comment 2

[Alessandro Castellani [:aleca]]

Comment on attachment 9133607 [details] [diff] [review]
1622860-Mac-AB-composer-titlebar.patch

Review of attachment 9133607 [details] [diff] [review]:
-----------------------------------------------------------------

This looks extremely good, thanks for taking care of it.
I don't know much about the reasons behind using/not using the titlebar, is there any downside to this?
Let's ping magnus to see what he things about this solution.

Comment 3

[Richard Marti (:Paenglab)]

On Mac I see no negative to use it as Mac doesn't have a context menu in the titlebar.

Comment 4

[Magnus Melin [:mkmelin]]

Comment on attachment 9133607 [details] [diff] [review]
1622860-Mac-AB-composer-titlebar.patch

Review of attachment 9133607 [details] [diff] [review]:
-----------------------------------------------------------------

(I don't have anything to add.)

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/86329202745b
macOS: Use always drawInTitlebar for the Address Book and the composer windows. r=aleca