Closed Bug 1622860 Opened 5 months ago Closed 5 months ago

Titlebar of Address Book and composer light when dark theme is chosen

Categories

(Thunderbird :: Theme, enhancement)

All
macOS
enhancement
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 76.0

People

(Reporter: Paenglab, Assigned: Paenglab)

Details

Attachments

(1 file)

The Address Book and the composer window have with the default TB theme a unified title-/toolbar. When a theme is chosen the toolbars are correctly painted but the titlebar is now light and no more unified with the toolbar. With the dark system theme it's worse because the light titlebars stand out more.

This is a little bit hacky because the titlebar is inside the toolbox but this fixes the issue and shows always a unified title-/toolbar. Actually the titlebar construct is no more used, with this patch it's used again.

Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #9133607 - Flags: review?(alessandro)
Comment on attachment 9133607 [details] [diff] [review]
1622860-Mac-AB-composer-titlebar.patch

Review of attachment 9133607 [details] [diff] [review]:
-----------------------------------------------------------------

This looks extremely good, thanks for taking care of it.
I don't know much about the reasons behind using/not using the titlebar, is there any downside to this?
Let's ping magnus to see what he things about this solution.
Attachment #9133607 - Flags: review?(mkmelin+mozilla)
Attachment #9133607 - Flags: review?(alessandro)
Attachment #9133607 - Flags: review+

On Mac I see no negative to use it as Mac doesn't have a context menu in the titlebar.

Comment on attachment 9133607 [details] [diff] [review]
1622860-Mac-AB-composer-titlebar.patch

Review of attachment 9133607 [details] [diff] [review]:
-----------------------------------------------------------------

(I don't have anything to add.)
Attachment #9133607 - Flags: review?(mkmelin+mozilla)

Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/86329202745b
macOS: Use always drawInTitlebar for the Address Book and the composer windows. r=aleca

Status: ASSIGNED → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 76.0
You need to log in before you can comment on or make changes to this bug.