Closed Bug 1622868 Opened 4 years ago Closed 4 years ago

Fix ns*String pretty-printers

Categories

(Developer Infrastructure :: Developer Environment Integration, defect)

defect
Not set
normal

Tracking

(firefox76 fixed)

RESOLVED FIXED
mozilla76
Tracking Status
firefox76 --- fixed

People

(Reporter: nika, Assigned: nika)

Details

Attachments

(1 file)

When bug 1393230 was landed to make our nsTString types use proper templates instead of macros, the symbols for these types visible to gdb changed. This appears to have broken pretty-printing support.

This patch changes the regex used to ^nsTString<.*>$ to match against these new symbols.

I considered trying to match on nsTSubstring<.*> or nsTStringRepr<.*> instead, but I wasn't confident how that would impact the pretty-printing behaviour, so I stuck with this smaller change.

Assignee: nobody → nika
Status: NEW → ASSIGNED
Pushed by nlayzell@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ca3d1bf6e97f
Fix ns*String pretty-printers, r=glandium
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla76
Product: Firefox Build System → Developer Infrastructure
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: