1622887 - Properly support js components implementing an [optional] out nsISupports

Status: RESOLVED FIXED

(Core :: XPConnect, defect)

Description

[Marco Bonardo [:mak]]

In bug 1496578 I'm converting nsDefaultURIFixup to js, the idl contains a couple methods that take an [optional] out nsIInputStream aPostData parameter.

Most of the cpp callers just pass nullptr for the optional out parameter, and that works currently because we call cpp from cpp. Once I convert the component to JS, we cross xpconnect and it doesn't work, we crash in nsXPCWrappedJS::CallMethod when we try to ZeroValue the null pointer... After fixing that, we then fail when trying to convert object.value.

We could either:

1. disallow [optional] out nsISupports
2. force consumers to pass in a refcounted pointer even if this is optional
3. properly support it

I have a patch for 3. but it's up for discussion.

Comment 1

[Marco Bonardo [:mak]]

Attachment: Bug 1622887 - Properly support js components implementing an [optional] out nsISupports. r=nika

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/330b0ebfad73
Properly support js components implementing an [optional] out nsISupports. r=nika

Comment 3

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/330b0ebfad73