1622919 - Picture-in-Picture toggle should re-evaluate visibility on video duration change

Status: VERIFIED FIXED

(Toolkit :: Video/Audio Controls, enhancement)

Description

[Mike Conley (:mconley) (:⚙️)]

Currently, we use some heuristics to determine whether or not to display the toggle. One heuristic we use is to only show the toggle for videos that are 45 seconds or longer. This works well on most sites, but on some sites, the duration on the video element changes after the metadata has been made available.

Live videos on https://www.cbc.ca/news, for example, are like this.

We should listen for the durationchange event, and re-evaluate the visibility of the toggle.

Comment 1

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1622919 - Re-evaluate displaying the Picture-in-Picture toggle on durationchange video events. r?mstriemer!

Unfortuntely, this seems pretty hard to write an automated test for -
I can't seem to tease our media stack into firing durationchange
events, or tricking the video into thinking its duration has
gotten longer.

Comment 2

[Mike Conley (:mconley) (:⚙️)]

I did test this manually by visiting https://www.cbc.ca/news/politics/trudeau-covid19-premiers-address-1.5506473 during the live broadcast. This tests the no-controls case out of the box. I was able to test the controls case by running this in the console before clicking "play" on the video:

document.querySelectorAll("video").forEach(v => v.setAttribute("controls", true));

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/76b49244a016
Re-evaluate displaying the Picture-in-Picture toggle on durationchange video events. r=mstriemer

Comment 4

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/76b49244a016

Comment 5

[Oana Botisan, Desktop QA]

I managed to reproduce the issue using an older version of Nightly (2020-03-16) on Windows 10 x64.
I retested everything using latest Nightly 77.0a1 and Firefox 76.0b4 on macOS 10.11, Ubuntu 18.04 x64 and Windows 10 x64. The issue is not reproducing anymore.