1624702 - Write a Picture-in-Picture toggle behaviour test for the durationchange event

Status: RESOLVED FIXED

(Toolkit :: Video/Audio Controls, task, P3)

Description

[Mike Conley (:mconley) (:⚙️) (PTO: May 24 - June 2nd)]

Bug 1622919 landed a change that makes the videocontrols UAWidget re-evaluate displaying the Picture-in-Picture toggle on <video> elements that fire the durationchange event.

We should add a test for this. Originally, this seemed to be difficult to test, since mocking out the duration on a video seemed hard, creating a 45 second video for the test seemed like a waste of space in the repository, and generating a 45 second video dynamically seemed really hard.

One idea is to add a new pref that controls the minimum length of video for showing the toggle, and poking that before the test begins. Then, we could switch the <source> on the video between a shorter and longer video to test the behaviour.

Comment 1

[Mike Conley (:mconley) (:⚙️) (PTO: May 24 - June 2nd)]

Attachment: Bug 1624702 - Get rid of some dead Picture-in-Picture prefs. r?jaws!

Comment 2

[Mike Conley (:mconley) (:⚙️) (PTO: May 24 - June 2nd)]

Attachment: Bug 1624702 - Add a preference to control the minimum video length for displaying the Picture-in-Picture toggle. r?jaws!

Depends on D68821

Comment 3

[Mike Conley (:mconley) (:⚙️) (PTO: May 24 - June 2nd)]

Attachment: Bug 1624702 - Test that the Picture-in-Picture toggle visibility is re-evaluated if the duration of the video changes. r?jaws!

Depends on D68822

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fe036026a187
Get rid of some dead Picture-in-Picture prefs. r=jaws
https://hg.mozilla.org/integration/autoland/rev/adf32b9c3214
Add a preference to control the minimum video length for displaying the Picture-in-Picture toggle. r=jaws
https://hg.mozilla.org/integration/autoland/rev/cd77dcb0cd4e
Test that the Picture-in-Picture toggle visibility is re-evaluated if the duration of the video changes. r=jaws

Comment 5

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/fe036026a187
https://hg.mozilla.org/mozilla-central/rev/adf32b9c3214
https://hg.mozilla.org/mozilla-central/rev/cd77dcb0cd4e

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Tracking+ due to the test permafails in bug 1626948 fixed by this.