1622947 - input type="number" with datalist, repeat up/down keys increases or decreases values only once

Status: NEW

(Core :: Layout: Form Controls, defect, P3)

Description

[Alice0775 White]

After landing Bug 1620778,

Str:

1. Open http://jsbin.com/quluwijohe/1/edit
2. Focus the field
3. Repeat keypress ↑ or ↓

Actual results:

Strange behavior.
The value increases or decreases only once.

Expected results:
The value increases or decreases with each keypress.

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Hmmm, fantastic fail on my side, I was pretty sure I had tested that case...

Thanks for reporting as always Alice, you're amazing.

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Huh, I can't repro on Linux... Is this on Windows?

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Or, does the autocomplete popup show up once after you press it? If so it's a kinda weird interaction because it shows up when there are results that match the input value, but it's not clear what would be the right interaction there...

Maybe we could suppress the popup if there's a repeating keypress somehow.

Comment 4

[Alice0775 White]

(In reply to Emilio Cobos Álvarez (:emilio) from comment #2)

Huh, I can't repro on Linux... Is this on Windows?

Yes, windows.

Comment 5

[Emilio Cobos Álvarez (:emilio)]

What about the question in comment 3? Thank you.

Comment 6

[Alice0775 White]

(In reply to Emilio Cobos Álvarez (:emilio) from comment #3)

Or, does the autocomplete popup show up once after you press it?

Yes.

If so it's a kinda weird interaction because it shows up when there are results that match the input value,
but it's not clear what would be the right interaction there...

Maybe we could suppress the popup if there's a repeating keypress somehow.

Yes, but it is complicated. It needs to organize how to interact with the keyboard...

Comment 7

[Tim Spurway [:tspurway]]

Hi Emilio - are you planning on working on this for 76 during the beta?

Comment 8

[Emilio Cobos Álvarez (:emilio)]

I thought this was a somewhat more serious issue at first, I don't think it's a P2.

This probably needs some UX input or something.

Comment 9

[BugBot [:suhaib / :marco/ :calixte]]

Changing the priority to p2 as the bug is tracked by a release manager for the current nightly.
See What Do You Triage for more information

Comment 10

[Sean Voisen (:svoisen)]

It does feel broken, and yes I think we need some UX input. Doesn't seem like there is much standard behavior. Trying this on Mac in both Firefox and Chrome:

1. On initial focus and pressing ↓: For Firefox, I get a negative value, no popup. On Chrome the popup appears on initial focus and I select a value from the datalist. Chrome feels better in this case.
2. On initial focus and pressing ↑: For Firefox, the popup appears after pressing ↑ and I select a value. On Chrome the popup appears on initial focus but ↑ does nothing (presumably because the popup is below). Firefox feels better in this case.
3. After selecting an item from the data list and pressing ↑ or ↓ multiple times: For Firefox, it feels broken at this point. You can't nudge values up or down, but the popup appears. On Chrome it also feels broken; you can nudge values up and down, but the popup will no longer appear. Chrome seems better, but both feel broken for different reasons.

Stephen do you know who could provide input on how this should work?

Comment 11

[Sean Voisen (:svoisen)]

Ryan: Based on comment 8 do you think we should keep tracking? I'd prioritize this as P3 and not track it. It's kind of wonky in Firefox and Chrome for different reasons.

If anything we should simply fix it so that the popup appears on first ↑ or ↓ (or on focus) but we don't increment or decrement the value in the field while the popup is open.

Comment 12

[Ryan VanderMeulen [:RyanVM]]

Sounds reasonable.

Comment 13

[Jens Stutte [:jstutte]]

(In reply to Sean Voisen (:svoisen) from comment #11)

Ryan: Based on comment 8 do you think we should keep tracking? I'd prioritize this as P3 and not track it. It's kind of wonky in Firefox and Chrome for different reasons.

If anything we should simply fix it so that the popup appears on first ↑ or ↓ (or on focus) but we don't increment or decrement the value in the field while the popup is open.

I just set the priority accordingly.

Comment 14

[BugBot [:suhaib / :marco/ :calixte]]

Clear a needinfo that is pending on an inactive user.

Inactive users most likely will not respond; if the missing information is essential and cannot be collected another way, the bug maybe should be closed as INCOMPLETE.

For more information, please visit BugBot documentation.