1623132 - Remove python2-only configobj from the tree

Status: RESOLVED FIXED

(Firefox Build System :: General, task)

Description

[William Lachance (:wlach)]

It's only consumer is printconfigsetting.py and that's easy to rewrite to use python's configparser (in a portable way between python 2 + 3).

At the same time we can simplify the script somewhat. e.g. the logic to rewrite ; comments as # is no longer necessary:

https://bugzilla.mozilla.org/show_bug.cgi?id=957911#c6

Comment 1

[William Lachance (:wlach)]

Attachment: Bug 1623132 - Rewrite printconfigparser to use configparser, python 3 r?rstewart

Comment 2

[William Lachance (:wlach)]

Attachment: Bug 1623132 - Remove now-unneeded configobj library r?rstewart

Depends on D67206

Comment 3

[William Lachance (:wlach)]

Attachment: Bug 1623132 - Rewrite printconfigsetting to use configparser, python 3 r?rstewart

Comment 4

[William Lachance (:wlach)]

ahal helpfully suggested that I could just make all invocations of it use python3, so doing that instead of making it continue to run under python 2. That simplifies it a bunch, would probably be even better if we could just get rid of it but that would take more time than I'm willing to spend on this right now (this is a diversion of a diversion).

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/255f5213cfd5
Rewrite printconfigsetting to use configparser, python 3 r=rstewart

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/87ace554c385
Remove now-unneeded configobj library r=rstewart

Comment 7

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/255f5213cfd5
https://hg.mozilla.org/mozilla-central/rev/87ace554c385