Closed Bug 1623132 Opened 6 months ago Closed 6 months ago

Remove python2-only configobj from the tree

Categories

(Firefox Build System :: General, task)

task
Not set
normal

Tracking

(firefox76 fixed)

RESOLVED FIXED
mozilla76
Tracking Status
firefox76 --- fixed

People

(Reporter: wlach, Assigned: wlach)

References

Details

Attachments

(2 files, 1 obsolete file)

It's only consumer is printconfigsetting.py and that's easy to rewrite to use python's configparser (in a portable way between python 2 + 3).

At the same time we can simplify the script somewhat. e.g. the logic to rewrite ; comments as # is no longer necessary:

https://bugzilla.mozilla.org/show_bug.cgi?id=957911#c6

Attachment #9133947 - Attachment is obsolete: true
Summary: Remove configobj from the tree → Remove python2-only configobj from the tree

ahal helpfully suggested that I could just make all invocations of it use python3, so doing that instead of making it continue to run under python 2. That simplifies it a bunch, would probably be even better if we could just get rid of it but that would take more time than I'm willing to spend on this right now (this is a diversion of a diversion).

Pushed by wlachance@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/255f5213cfd5
Rewrite printconfigsetting to use configparser, python 3 r=rstewart
Pushed by wlachance@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/87ace554c385
Remove now-unneeded configobj library r=rstewart
Status: NEW → RESOLVED
Closed: 6 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla76
Regressions: 1628200
You need to log in before you can comment on or make changes to this bug.