1628200 - config/tests/test_mozbuild_reading.py is busted

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Mike Hommey [:glandium]]

The error is:

E           BuildReaderError: 
E           ==============================
E           FATAL ERROR PROCESSING MOZBUILD FILE
E           ==============================
E           
E           The error occurred while processing the following file:
E           
E               /tmp/gecko/browser/app/winlauncher/freestanding/moz.build
E           
E           The error was triggered on line 50 of this file:
E           
E               flags=[CONFIG['LLVM_DLLTOOL']] + CONFIG['LLVM_DLLTOOL_FLAGS'])
E           
E           An error was encountered as part of executing the file itself. The error appears to be the fault of the script.
E           
E           The error as reported by Python is:
E           
E               ['TypeError: can only concatenate list (not "NoneType") to list\n']

But fixing that one unveils a ton more.

Comment 1

[Mike Hommey [:glandium]]

Attachment: Bug 1628200 - Fix config/tests/test_mozbuild_reading.py.

Since the test goes through all moz.build files disregarding DIRS and
the conditions that may disable directories, in some cases, moz.builds
can fail to be evaluated properly because of missing variables in
config.status. This time (because it's not the first), it's
LLVM_DLLTOOL.

After fixing that, it turns out many of the files/directories pointed to
by Files() directives were removed or moved.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/35a1ebbb1099
Fix config/tests/test_mozbuild_reading.py. r=rstewart

Comment 3

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/35a1ebbb1099