1623195 - Use updated Variant::match with 2-arg lambda in Serializer<Variant>

Status: RESOLVED FIXED

(Core :: Gecko Profiler, task, P2)

Description

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Use updated Variant::match() with 2-arg lambda in ProfileBufferEntryWriter::Serializer<Variant<...>>.

Comment 1

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Attachment: Bug 1623195 - Optimize ProfileBufferEntryWriter::Serializer<Variant> - r?canaltinova!,gregtatum

The old code was using std::index_sequence_for to call templated functions for
every possible Variant alternative.
Instead, using Variant::match() with a generic lambda (that also takes the
current Variant index, thanks to bug 1621865) means we're only calling the
function corresponding to the current alternative.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/12f26ec64fee
Optimize ProfileBufferEntryWriter::Serializer<Variant> - r=canaltinova

Comment 3

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/12f26ec64fee