1623268 - Refine ContentBlocking::AllowAccessFor

Status: RESOLVED FIXED

(Core :: Privacy: Anti-Tracking, task, P1)

Comment 1

[Dimi Lee [:dimi]]

The code in the function is not easy to read. Let's refine it to make the future fission-compatible work easier.

Comment 2

[Dimi Lee [:dimi]]

Attachment: Bug 1623268 - P1. Use BrowsingContext::IsTopContent r=timhuang

Comment 3

[Dimi Lee [:dimi]]

Attachment: Bug 1623268 - P2. Refine the logic of third-party checks in ContentBlocking::AllowAccessFor r=timhuang

This patch doesn't change the current behavior.
The intention is to make this code section easier to understand.

Depends on D67281

Comment 4

[Dimi Lee [:dimi]]

Attachment: Bug 1623268 - P3. ContentBlockingAllowList::Check API supports passing BrowsingContext r=timhuang

Depends on D67282

Comment 5

[Dimi Lee [:dimi]]

Attachment: Bug 1623268 - P4. Rename and reorder variables in ContentBlocking::AllowAccessFor r=timhuang

This patch does the following:

• declare local variables right before they are used.
• remove unused local variables.
• rename local variables to make its purpose more clear

Depends on D67283

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/270ba3bd1c22
P1. Use BrowsingContext::IsTopContent r=timhuang,baku
https://hg.mozilla.org/integration/autoland/rev/5072342655d8
P2. Refine the logic of third-party checks in ContentBlocking::AllowAccessFor r=timhuang,baku
https://hg.mozilla.org/integration/autoland/rev/f89b7ec7b51b
P3. ContentBlockingAllowList::Check API supports passing BrowsingContext r=timhuang,baku
https://hg.mozilla.org/integration/autoland/rev/a217ec8bc94e
P4. Rename and reorder variables in ContentBlocking::AllowAccessFor r=timhuang,baku

Comment 7

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/270ba3bd1c22
https://hg.mozilla.org/mozilla-central/rev/5072342655d8
https://hg.mozilla.org/mozilla-central/rev/f89b7ec7b51b
https://hg.mozilla.org/mozilla-central/rev/a217ec8bc94e